Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1188713004: Add setSinkId method to WebMediaPlayer. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add setSinkId method to WebMediaPlayer. This is inteded to support the Audio Output Devices API (http://w3c.github.io/mediacapture-output/) https://www.chromestatus.com/feature/4621603249848320 BUG=438023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M public/platform/WebMediaPlayer.h View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Guido Urdaneta
Hi, please review. wolenetz: As agreed, this includes the comment about threading and the WebCallbacks ...
4 years, 10 months ago (2015-06-16 10:50:06 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2015-06-16 14:45:24 UTC) #4
tkent
lgtm
4 years, 10 months ago (2015-06-17 00:36:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188713004/1
4 years, 10 months ago (2015-06-17 00:39:16 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 00:43:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197215

Powered by Google App Engine
This is Rietveld 408576698