Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 11887034: [Android] Remove some unneeded gyp defines. (Closed)

Created:
7 years, 11 months ago by Yaron
Modified:
7 years, 11 months ago
Reviewers:
cjhopman, Torne
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Remove some unneeded gyp defines. These are crufy and not needed anymore. A follow-up will start pushing used defines into gyp. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M build/android/envsetup_functions.sh View 2 chunks +0 lines, -8 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yaron
7 years, 11 months ago (2013-01-15 19:55:17 UTC) #1
Torne
lgtm
7 years, 11 months ago (2013-01-15 21:11:23 UTC) #2
cjhopman
7 years, 11 months ago (2013-01-15 21:12:20 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698