cc: Add iterator and big border support to TilingData

cc/tiling_data.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tiling_data.h"
 
 #include <algorithm>
 
 #include "ui/gfx/rect.h"
 #include "ui/gfx/vector2d.h"
 
 namespace cc {
 
 static int ComputeNumTiles(int max_texture_size, int total_size, int border_texels) {
   if (max_texture_size - 2 * border_texels <= 0)
     return total_size > 0 && max_texture_size >= total_size ? 1 : 0;
 
   int num_tiles = std::max(1, 1 + (total_size - 1 - 2 * border_texels) / (max_texture_size - 2 * border_texels));
   return total_size > 0 ? num_tiles : 0;
 }
 
-TilingData::TilingData(gfx::Size max_texture_size, gfx::Size total_size, bool hasBorderTexels)
+TilingData::TilingData(
+    gfx::Size max_texture_size,
+    gfx::Size total_size,
+    bool hasBorderTexels)
     : max_texture_size_(max_texture_size),
       total_size_(total_size),
       border_texels_(hasBorderTexels ? 1 : 0) {
   RecomputeNumTiles();
 }
 
-TilingData::~TilingData() {
+TilingData::TilingData(
+    gfx::Size max_texture_size,
+    gfx::Size total_size,
+    int border_texels)
+    : max_texture_size_(max_texture_size),
+      total_size_(total_size),
+      border_texels_(border_texels) {
+  RecomputeNumTiles();
 }
 
 void TilingData::SetTotalSize(gfx::Size total_size) {
   total_size_ = total_size;
   RecomputeNumTiles();
 }
 
 void TilingData::SetMaxTextureSize(gfx::Size max_texture_size) {
   max_texture_size_ = max_texture_size;
   RecomputeNumTiles();
 }
 
 void TilingData::SetHasBorderTexels(bool has_border_texels) {
   border_texels_ = has_border_texels ? 1 : 0;
   RecomputeNumTiles();
 }
 
+void TilingData::SetBorderTexels(int border_texels) {
+  border_texels_ = border_texels;
+  RecomputeNumTiles();
+}
+
 int TilingData::TileXIndexFromSrcCoord(int src_position) const {
   if (num_tiles_x_ <= 1)
     return 0;
 
-  DCHECK(max_texture_size_.width() - 2 * border_texels_);
-  int x = (src_position - border_texels_) / (max_texture_size_.width() - 2 * border_texels_);
+  DCHECK_GT(max_texture_size_.width() - 2 * border_texels_, 0);
+  int x = (src_position - border_texels_) /
+      (max_texture_size_.width() - 2 * border_texels_);
   return std::min(std::max(x, 0), num_tiles_x_ - 1);
 }
 
 int TilingData::TileYIndexFromSrcCoord(int src_position) const {
   if (num_tiles_y_ <= 1)
     return 0;
 
-  DCHECK(max_texture_size_.height() - 2 * border_texels_);
-  int y = (src_position - border_texels_) / (max_texture_size_.height() - 2 * border_texels_);
+  DCHECK_GT(max_texture_size_.width() - 2 * border_texels_, 0);

[danakj, 2013/01/15 23:09:05]

did you mean to change this to width?

[enne (OOO), 2013/01/15 23:31:40]

Done.

+  int y = (src_position - border_texels_) /
+      (max_texture_size_.height() - 2 * border_texels_);
   return std::min(std::max(y, 0), num_tiles_y_ - 1);
 }
 
+int TilingData::BorderTileXIndexFromSrcCoord(int src_position) const {
+  if (num_tiles_x_ <= 1)
+    return 0;
+
+  DCHECK_GT(max_texture_size_.width() - 2 * border_texels_, 0);
+  int inner_tile_size = max_texture_size_.width() - 2 * border_texels_;
+  int x = (src_position - 2 * border_texels_) / inner_tile_size;
+  return std::min(std::max(x, 0), num_tiles_x_ - 1);
+}
+
+int TilingData::BorderTileYIndexFromSrcCoord(int src_position) const {
+  if (num_tiles_y_ <= 1)
+    return 0;
+
+  DCHECK_GT(max_texture_size_.width() - 2 * border_texels_, 0);

[danakj, 2013/01/15 23:09:05]

should this be .height()?

[enne (OOO), 2013/01/15 23:31:40]

Done.

+  int inner_tile_size = max_texture_size_.height() - 2 * border_texels_;
+  int y = (src_position - 2 * border_texels_) / inner_tile_size;
+  return std::min(std::max(y, 0), num_tiles_y_ - 1);
+}
+
 gfx::Rect TilingData::TileBounds(int i, int j) const {
   AssertTile(i, j);
   int x = TilePositionX(i);
   int y = TilePositionY(j);
   int width = TileSizeX(i);
   int height = TileSizeY(j);
   DCHECK_GE(x, 0);
   DCHECK_GE(y, 0);
   DCHECK_GE(width, 0);
   DCHECK_GE(height, 0);
   DCHECK_LE(x, total_size_.width());
   DCHECK_LE(y, total_size_.height());
   return gfx::Rect(x, y, width, height);
 }
 
 gfx::Rect TilingData::TileBoundsWithBorder(int i, int j) const {
   gfx::Rect bounds = TileBounds(i, j);
 
   if (border_texels_) {
     int x1 = bounds.x();
     int x2 = bounds.right();
     int y1 = bounds.y();
     int y2 = bounds.bottom();
 
     if (i > 0)
-      x1--;
+      x1-= border_texels_;
     if (i < (num_tiles_x_ - 1))
-      x2++;
+      x2+= border_texels_;
     if (j > 0)
-      y1--;
+      y1-= border_texels_;
     if (j < (num_tiles_y_ - 1))
-      y2++;
+      y2+= border_texels_;
 
     bounds = gfx::Rect(x1, y1, x2 - x1, y2 - y1);
   }
 
   return bounds;
 }
 
 int TilingData::TilePositionX(int x_index) const {
   DCHECK_GE(x_index, 0);
   DCHECK_LT(x_index, num_tiles_x_);
@@ skipping 55 matching lines @@
   int top = (!y_index || num_tiles_y_ == 1) ? 0 : border_texels_;
 
   return gfx::Vector2d(left, top);
 }
 
 void TilingData::RecomputeNumTiles() {
   num_tiles_x_ = ComputeNumTiles(max_texture_size_.width(), total_size_.width(), border_texels_);
   num_tiles_y_ = ComputeNumTiles(max_texture_size_.height(), total_size_.height(), border_texels_);
 }
 
+TilingData::Iterator::Iterator(const TilingData* tiling_data, gfx::Rect rect)
+    : tiling_data_(tiling_data) {
+  rect_ = gfx::IntersectRects(rect, gfx::Rect(tiling_data_->total_size()));

[danakj, 2013/01/15 23:09:05]

why isn't this set via constructor initialization? should it be?

[enne (OOO), 2013/01/15 23:31:40]

Done.

+  if (tiling_data_->num_tiles_x() > 0 && tiling_data_->num_tiles_y() > 0) {

[danakj, 2013/01/15 23:09:05]

nit: invert this and done(); return; instead of nesting the whole function?

[enne (OOO), 2013/01/15 23:31:40]

Done().

+    index_x_ = tiling_data_->BorderTileXIndexFromSrcCoord(rect_.x());
+    index_y_ = tiling_data_->BorderTileYIndexFromSrcCoord(rect_.y());
+
+    // Index functions always return valid indices, so explicitly check
+    // for non-intersecting rects.
+    gfx::Rect new_rect = tiling_data_->TileBoundsWithBorder(index_x_, index_y_);
+    if (!new_rect.Intersects(rect_))
+      done();
+  } else {
+    done();
+  }
+}
+
+TilingData::Iterator& TilingData::Iterator::operator++() {
+  index_x_++;

[danakj, 2013/01/15 23:09:05]

DCHECK(index_x_ >= 0 && index_y_ >= 0) and early out to avoid shinanigans?

[enne (OOO), 2013/01/15 23:31:40]

Actually, multiple calls to ++ on a "done" iterator should be a silent no-op.

+
+  bool new_row = index_x_ >= tiling_data_->num_tiles_x();
+  if (!new_row) {
+    gfx::Rect new_rect = tiling_data_->TileBoundsWithBorder(index_x_, index_y_);
+    new_row = new_rect.x() >= rect_.right();
+  }
+
+  if (new_row) {
+    index_x_ = tiling_data_->BorderTileXIndexFromSrcCoord(rect_.x());
+    index_y_++;
+
+    if (index_y_ >= tiling_data_->num_tiles_y())

[danakj, 2013/01/15 23:09:05]

nit: if one block gets {} they all do, in chromium

[enne (OOO), 2013/01/15 23:31:40]

What do you know, a part of Chromium style I like!  Done.

+      done();
+    else {
+      gfx::Rect new_rect =
+          tiling_data_->TileBoundsWithBorder(index_x_, index_y_);
+      if (new_rect.y() >= rect_.bottom())
+        done();
+    }
+  }
+
+  return *this;
+}
+
+TilingData::Iterator::operator bool() const {
+  return index_x_ != -1 && index_y_ != -1;
+}
+
+void TilingData::Iterator::done() {
+  index_x_ = -1;
+  index_y_ = -1;
+}
+
 }  // namespace cc