Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: pkg/http/lib/src/multipart_request.dart

Issue 11887016: Make StreamController's unnamed constructor create a single-sub stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/http/lib/src/streamed_request.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library multipart_request; 5 library multipart_request;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'dart:math'; 9 import 'dart:math';
10 import 'dart:uri'; 10 import 'dart:uri';
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 /// Freezes all mutable fields and returns a single-subscription [ByteStream] 88 /// Freezes all mutable fields and returns a single-subscription [ByteStream]
89 /// that will emit the request body. 89 /// that will emit the request body.
90 ByteStream finalize() { 90 ByteStream finalize() {
91 // TODO(nweiz): freeze fields and files 91 // TODO(nweiz): freeze fields and files
92 var boundary = _boundaryString(_BOUNDARY_LENGTH); 92 var boundary = _boundaryString(_BOUNDARY_LENGTH);
93 headers['content-type'] = 'multipart/form-data; boundary="$boundary"'; 93 headers['content-type'] = 'multipart/form-data; boundary="$boundary"';
94 headers['content-transfer-encoding'] = 'binary'; 94 headers['content-transfer-encoding'] = 'binary';
95 super.finalize(); 95 super.finalize();
96 96
97 var controller = new StreamController<List<int>>.singleSubscription(); 97 var controller = new StreamController<List<int>>();
98 98
99 void writeAscii(String string) { 99 void writeAscii(String string) {
100 assert(isPlainAscii(string)); 100 assert(isPlainAscii(string));
101 controller.add(string.charCodes); 101 controller.add(string.charCodes);
102 } 102 }
103 103
104 writeUtf8(String string) => controller.add(encodeUtf8(string)); 104 writeUtf8(String string) => controller.add(encodeUtf8(string));
105 writeLine() => controller.add([13, 10]); // \r\n 105 writeLine() => controller.add([13, 10]); // \r\n
106 106
107 fields.forEach((name, value) { 107 fields.forEach((name, value) {
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 String _boundaryString(int length) { 166 String _boundaryString(int length) {
167 var prefix = "dart-http-boundary-"; 167 var prefix = "dart-http-boundary-";
168 var list = new List<int>.fixedLength(length - prefix.length); 168 var list = new List<int>.fixedLength(length - prefix.length);
169 for (var i = 0; i < list.length; i++) { 169 for (var i = 0; i < list.length; i++) {
170 list[i] = _BOUNDARY_CHARACTERS[ 170 list[i] = _BOUNDARY_CHARACTERS[
171 _random.nextInt(_BOUNDARY_CHARACTERS.length)]; 171 _random.nextInt(_BOUNDARY_CHARACTERS.length)];
172 } 172 }
173 return "$prefix${new String.fromCharCodes(list)}"; 173 return "$prefix${new String.fromCharCodes(list)}";
174 } 174 }
175 } 175 }
OLDNEW
« no previous file with comments | « no previous file | pkg/http/lib/src/streamed_request.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698