Tighten up media::DecoderBuffer data requirements.

media/base/decoder_buffer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/decoder_buffer.h"
 
 #include "base/logging.h"
 #include "media/base/decrypt_config.h"
 
 namespace media {
 
 DecoderBuffer::DecoderBuffer(int buffer_size)
     : buffer_size_(buffer_size) {
   Initialize();
 }
 
 DecoderBuffer::DecoderBuffer(const uint8* data, int buffer_size)
     : buffer_size_(buffer_size) {
-  // Prevent invalid allocations.  Also used to create end of stream buffers.
-  if (!data || buffer_size <= 0) {
+  if (!data) {
     buffer_size_ = 0;

[acolwell GONE FROM CHROMIUM, 2013/01/17 00:00:08]

nit: CHECK_EQ(buffer_size, 0);

[scherkus (not reviewing), 2013/01/17 00:16:30]

Done.

     return;
   }
 
   Initialize();
   memcpy(data_.get(), data, buffer_size_);
 }
 
 DecoderBuffer::~DecoderBuffer() {}
 
 void DecoderBuffer::Initialize() {
   DCHECK_GE(buffer_size_, 0);
   data_.reset(reinterpret_cast<uint8*>(
       base::AlignedAlloc(buffer_size_ + kPaddingSize, kAlignmentSize)));
   memset(data_.get() + buffer_size_, 0, kPaddingSize);
 }
 
 scoped_refptr<DecoderBuffer> DecoderBuffer::CopyFrom(const uint8* data,
                                                      int data_size) {
-  DCHECK(data);
+  // If you hit these checks you likely have a bug in a demuxer. Go fix it.
+  CHECK(data);
+  CHECK_GE(data_size, 0);

[acolwell GONE FROM CHROMIUM, 2013/01/17 00:00:08]

nit: Perhaps move this one into the constructor?

[scherkus (not reviewing), 2013/01/17 00:16:30]

Looks like a DCHECK equivalent is in Initialize() -- made that one a CHECK()
instead

   return make_scoped_refptr(new DecoderBuffer(data, data_size));
 }
 
 scoped_refptr<DecoderBuffer> DecoderBuffer::CreateEOSBuffer() {
   return make_scoped_refptr(new DecoderBuffer(NULL, 0));
 }
 
 base::TimeDelta DecoderBuffer::GetTimestamp() const {
   return timestamp_;
 }
@@ skipping 28 matching lines @@
 
 void DecoderBuffer::SetDecryptConfig(scoped_ptr<DecryptConfig> decrypt_config) {
   decrypt_config_ = decrypt_config.Pass();
 }
 
 bool DecoderBuffer::IsEndOfStream() const {
   return data_ == NULL;
 }
 
 }  // namespace media