Enable options to remap CapsLock whenever an external keyboard is connected.

Enable options to remap CapsLock whenever an external keyboard is connected.

As per comments #16 and #17 on issue 167237, we will assume that most
external keyboards have a CapsLock key (chromeos external keyboards are
exceptions. However, there's no way to distinguish them at the moment).

This CL enables/disables the CapsLock remapping options in the keyboard
settings whenever there's an external keyboard is connected/disconnected
respectively.

BUG=167237
Committed: https://crrev.com/df45c0b5db1a68a59ee5c7a64a522f6d2de67b39
Cr-Commit-Position: refs/heads/master@{#334538}

[afakhry, 2015-06-15 23:45:49]

afakhry@chromium.org changed reviewers:
+ mukai@chromium.org

[afakhry, 2015-06-15 23:45:50]

mukai@: Could you please review this CL? Thanks!

[Jun Mukai, 2015-06-15 23:57:25]

lgtm

the patch looks good to me.  I have a question about the flag itself, but you
can deal with that in another CL.

https://codereview.chromium.org/1188693002/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc (left):

https://codereview.chromium.org/1188693002/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc:135:
chromeos::switches::kHasChromeOSKeyboard);
Do we need to keep this flag?
It looks like:
- defined in chromeos/chromeos_switches
- used only here
- referred in chrome/browser/chromeos/login/chrome_restart_request.cc, but it
looks like just copying the flag existence.
- chrome/browser/chromeos/events/event_rewriter_unittest.cc refers this flag,
but I'm not sure how this affects the test.


My bet is that this flag is almost deprecated, and you've removed the last
usage. If that's true, you can safely remove this flag itself.
You can remove the flag in another CL though.

[afakhry, 2015-06-16 00:52:47]

https://codereview.chromium.org/1188693002/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc (left):

https://codereview.chromium.org/1188693002/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc:135:
chromeos::switches::kHasChromeOSKeyboard);
On 2015/06/15 23:57:25, Jun Mukai wrote:
> Do we need to keep this flag?
> It looks like:
> - defined in chromeos/chromeos_switches
> - used only here
> - referred in chrome/browser/chromeos/login/chrome_restart_request.cc, but it
> looks like just copying the flag existence.
> - chrome/browser/chromeos/events/event_rewriter_unittest.cc refers this flag,
> but I'm not sure how this affects the test.
> 
> 
> My bet is that this flag is almost deprecated, and you've removed the last
> usage. If that's true, you can safely remove this flag itself.
> You can remove the flag in another CL though.

Yes I noticed that this flag is no longer used, but I wasn't sure if I should
remove it or if its removal should be part of this CL. I think I can remove it
in a follow-up CL as you suggested.

[afakhry, 2015-06-16 02:34:49]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2015-06-16 02:35:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1188693002/1

[commit-bot: I haz the power, 2015-06-16 02:54:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-16 02:55:36]

Patchset 1 (id:??) landed as
https://crrev.com/df45c0b5db1a68a59ee5c7a64a522f6d2de67b39
Cr-Commit-Position: refs/heads/master@{#334538}