Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1188643008: Fix test expectations for download_from_google_storage_unittests.py (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test expectations for download_from_google_storage_unittests.py This does not seem to be run by the bots, otherwise they should be red R=hinoka@google.com, iannucci@google.com BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M tests/download_from_google_storage_unittests.py View 6 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ricow1
feel free to land something else if the new error messages is not expected, I ...
5 years, 6 months ago (2015-06-18 12:56:29 UTC) #1
hinoka
lgtm thanks! I also verified locally.
5 years, 6 months ago (2015-06-18 17:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188643008/1
5 years, 6 months ago (2015-06-18 17:51:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295741
5 years, 6 months ago (2015-06-18 17:54:04 UTC) #6
iannucci
5 years, 6 months ago (2015-06-18 22:50:40 UTC) #8
Message was sent while issue was closed.
ah, lgtm

Powered by Google App Engine
This is Rietveld 408576698