Issue 1188633002: Fix iOS builds after ShellView refactor on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188633002: Fix iOS builds after ShellView refactor on Android (Closed)

Created:
5 years, 6 months ago by Chinmay

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	sky/shell/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/ios/platform_view_ios.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/ios/platform_view_ios.mm	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/shell/ios/sky_surface.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/shell/ios/sky_surface.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/shell/ios/sky_view_controller.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Chinmay

5 years, 6 months ago (2015-06-15 22:10:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8ff43d368427e8cc9931f68c1c357dca9635d1ad (presubmit successful).