ui/gfx/android/gfx_jni_registrar.cc - Issue 11886074: Use correct favicon scale factor on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/android/gfx_jni_registrar.cc

Issue 11886074: Use correct favicon scale factor on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments added; GetWidth() renamed to GetDisplayWidth() etc. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/gfx/android/gfx_jni_registrar.h"	5 #include "ui/gfx/android/gfx_jni_registrar.h"

6	6

	7 #include "ui/gfx/android/device_info.h"

	8

7 namespace gfx {	9 namespace gfx {

8	10

9 void RegisterBitmapAndroid(JNIEnv* env);	11 void RegisterBitmapAndroid(JNIEnv* env);

10	12

11 bool RegisterJni(JNIEnv* env) {	13 bool RegisterJni(JNIEnv* env) {

12 RegisterBitmapAndroid(env);	14 RegisterBitmapAndroid(env);
	Yaron 2013/01/17 00:38:48 Can you make this consistent with other registrars Can you make this consistent with other registrars? Declare an array of based::android::RegistrationMethod and call RegisterNativeMethods. aruslan 2013/01/17 02:11:47 Moved everything to ui/android/ui_jni_registrar.cc Show quoted text On 2013/01/17 00:38:48, Yaron wrote: > Can you make this consistent with other registrars? Declare an array of > based::android::RegistrationMethod and call RegisterNativeMethods. Moved everything to ui/android/ui_jni_registrar.cc.
13 return true;	15 return gfx::DeviceInfo::RegisterDeviceInfo(env);

14 }	16 }

15	17

16 } // namespace gfx	18 } // namespace gfx

OLD	NEW