Issue 11886071: Telemetry & Android: fix stderr / stdout getting mixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11886071: Telemetry & Android: fix stderr / stdout getting mixed. (Closed)

Created:
7 years, 11 months ago by marja

Modified:
7 years, 11 months ago

Reviewers:
bulach

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry & Android: fix stderr / stdout getting mixed. The benchmarks first print results to stdout, then information about skipped / failed page to stderr. The test runners also redirect both streams to the same file. If stdout is not properly flushed, the stderr output might appear in the middle of the stdout output, and this makes the log parser fail. R=bulach BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177162

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review (bulach) #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/android/pylib/perf_tests_helper.py	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm with one nit https://codereview.chromium.org/11886071/diff/1/build/android/pylib/perf_tests_helper.py File build/android/pylib/perf_tests_helper.py (right): https://codereview.chromium.org/11886071/diff/1/build/android/pylib/perf_tests_helper.py#newcode126 build/android/pylib/perf_tests_helper.py:126: import sys probably more common ...

7 years, 11 months ago (2013-01-16 17:23:26 UTC) #2

marja

7 years, 11 months ago (2013-01-16 17:25:26 UTC) #3

Thanks for review!

https://codereview.chromium.org/11886071/diff/1/build/android/pylib/perf_test...
File build/android/pylib/perf_tests_helper.py (right):

https://codereview.chromium.org/11886071/diff/1/build/android/pylib/perf_test...
build/android/pylib/perf_tests_helper.py:126: import sys
On 2013/01/16 17:23:26, bulach wrote:
> probably more common to import in the header as usual?

Done.

Expand Messages | Collapse Messages