Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11886064: Removed the 'we don't run multitests on browsers'-hack (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/language/language.status ('K') | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index ff466f686ec3280d4c722271a6a75d894825a5c3..5c5d966307ad9638ed5bbfc4955ef025f623379c 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -627,8 +627,6 @@ class StandardTestSuite extends TestSuite {
String testName;
if (optionsFromFile['isMultitest']) {
- // Multitests do not run on browsers.
- if (TestUtils.isBrowserRuntime(configuration['runtime'])) return;
// Multitests are in [build directory]/generated_tests/... .
// The test name will be '[test filename (no extension)]/[multitest key].
String name = filePath.filenameWithoutExtension;
@@ -1310,7 +1308,7 @@ class StandardTestSuite extends TestSuite {
RegExp libraryDefinitionRegExp =
new RegExp(r"^[#]?library[\( ]", multiLine: true);
RegExp sourceOrImportRegExp =
- new RegExp("^(#source|#import|part)[ \t]+[\('\"]", multiLine: true);
+ new RegExp("^(#?source|#?import|part)[ \t]+[\('\"]", multiLine: true);
kustermann 2013/01/16 17:54:55 This was broken before. After correcting this we'l
ahe 2013/01/16 17:57:25 We should reword the warning to inform the user th
var bytes = new File.fromPath(filePath).readAsBytesSync();
String contents = decodeUtf8(bytes);
« tests/language/language.status ('K') | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698