Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: src/IceTargetLoweringX8632.h

Issue 1188603002: Move lowerGlobal() from target-specific code to emitGlobal() in generic code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: .long vs .4byte Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceTargetLoweringMIPS32.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceTargetLoweringX8632.h - x86-32 lowering ---*- C++ -*-===// 1 //===- subzero/src/IceTargetLoweringX8632.h - x86-32 lowering ---*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the TargetLoweringX8632 class, which 10 // This file declares the TargetLoweringX8632 class, which
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx)); 587 return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
588 } 588 }
589 589
590 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override; 590 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
591 void lowerConstants() override; 591 void lowerConstants() override;
592 592
593 protected: 593 protected:
594 explicit TargetDataX8632(GlobalContext *Ctx); 594 explicit TargetDataX8632(GlobalContext *Ctx);
595 595
596 private: 596 private:
597 void lowerGlobal(const VariableDeclaration &Var);
598 ~TargetDataX8632() override {} 597 ~TargetDataX8632() override {}
599 template <typename T> static void emitConstantPool(GlobalContext *Ctx); 598 template <typename T> static void emitConstantPool(GlobalContext *Ctx);
600 }; 599 };
601 600
602 class TargetHeaderX8632 final : public TargetHeaderLowering { 601 class TargetHeaderX8632 final : public TargetHeaderLowering {
603 TargetHeaderX8632() = delete; 602 TargetHeaderX8632() = delete;
604 TargetHeaderX8632(const TargetHeaderX8632 &) = delete; 603 TargetHeaderX8632(const TargetHeaderX8632 &) = delete;
605 TargetHeaderX8632 &operator=(const TargetHeaderX8632 &) = delete; 604 TargetHeaderX8632 &operator=(const TargetHeaderX8632 &) = delete;
606 605
607 public: 606 public:
608 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) { 607 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
609 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderX8632(Ctx)); 608 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderX8632(Ctx));
610 } 609 }
611 610
612 protected: 611 protected:
613 explicit TargetHeaderX8632(GlobalContext *Ctx); 612 explicit TargetHeaderX8632(GlobalContext *Ctx);
614 613
615 private: 614 private:
616 ~TargetHeaderX8632() = default; 615 ~TargetHeaderX8632() = default;
617 }; 616 };
618 617
619 } // end of namespace Ice 618 } // end of namespace Ice
620 619
621 #endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H 620 #endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H
OLDNEW
« no previous file with comments | « src/IceTargetLoweringMIPS32.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698