Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: src/IceTargetLoweringMIPS32.h

Issue 1188603002: Move lowerGlobal() from target-specific code to emitGlobal() in generic code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: .long vs .4byte Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceTargetLoweringMIPS32.h - MIPS32 lowering ---*- C++-*-===// 1 //===- subzero/src/IceTargetLoweringMIPS32.h - MIPS32 lowering ---*- C++-*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the TargetLoweringMIPS32 class, which implements the 10 // This file declares the TargetLoweringMIPS32 class, which implements the
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 return std::unique_ptr<TargetDataLowering>(new TargetDataMIPS32(Ctx)); 137 return std::unique_ptr<TargetDataLowering>(new TargetDataMIPS32(Ctx));
138 } 138 }
139 139
140 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override; 140 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
141 void lowerConstants() override; 141 void lowerConstants() override;
142 142
143 protected: 143 protected:
144 explicit TargetDataMIPS32(GlobalContext *Ctx); 144 explicit TargetDataMIPS32(GlobalContext *Ctx);
145 145
146 private: 146 private:
147 void lowerGlobal(const VariableDeclaration &Var) const;
148 ~TargetDataMIPS32() override {} 147 ~TargetDataMIPS32() override {}
149 template <typename T> static void emitConstantPool(GlobalContext *Ctx); 148 template <typename T> static void emitConstantPool(GlobalContext *Ctx);
150 }; 149 };
151 150
152 class TargetHeaderMIPS32 final : public TargetHeaderLowering { 151 class TargetHeaderMIPS32 final : public TargetHeaderLowering {
153 TargetHeaderMIPS32() = delete; 152 TargetHeaderMIPS32() = delete;
154 TargetHeaderMIPS32(const TargetHeaderMIPS32 &) = delete; 153 TargetHeaderMIPS32(const TargetHeaderMIPS32 &) = delete;
155 TargetHeaderMIPS32 &operator=(const TargetHeaderMIPS32 &) = delete; 154 TargetHeaderMIPS32 &operator=(const TargetHeaderMIPS32 &) = delete;
156 155
157 public: 156 public:
158 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) { 157 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
159 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderMIPS32(Ctx)); 158 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderMIPS32(Ctx));
160 } 159 }
161 160
162 protected: 161 protected:
163 explicit TargetHeaderMIPS32(GlobalContext *Ctx); 162 explicit TargetHeaderMIPS32(GlobalContext *Ctx);
164 163
165 private: 164 private:
166 ~TargetHeaderMIPS32() = default; 165 ~TargetHeaderMIPS32() = default;
167 }; 166 };
168 167
169 } // end of namespace Ice 168 } // end of namespace Ice
170 169
171 #endif // SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H 170 #endif // SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H
OLDNEW
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698