Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: src/IceTargetLoweringARM32.h

Issue 1188603002: Move lowerGlobal() from target-specific code to emitGlobal() in generic code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: .long vs .4byte Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceTargetLoweringARM32.h - ARM32 lowering ----*- C++ -*-===// 1 //===- subzero/src/IceTargetLoweringARM32.h - ARM32 lowering ----*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the TargetLoweringARM32 class, which implements the 10 // This file declares the TargetLoweringARM32 class, which implements the
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 return std::unique_ptr<TargetDataLowering>(new TargetDataARM32(Ctx)); 312 return std::unique_ptr<TargetDataLowering>(new TargetDataARM32(Ctx));
313 } 313 }
314 314
315 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override; 315 void lowerGlobals(std::unique_ptr<VariableDeclarationList> Vars) override;
316 void lowerConstants() override; 316 void lowerConstants() override;
317 317
318 protected: 318 protected:
319 explicit TargetDataARM32(GlobalContext *Ctx); 319 explicit TargetDataARM32(GlobalContext *Ctx);
320 320
321 private: 321 private:
322 void lowerGlobal(const VariableDeclaration &Var) const;
323 ~TargetDataARM32() override {} 322 ~TargetDataARM32() override {}
324 template <typename T> static void emitConstantPool(GlobalContext *Ctx); 323 template <typename T> static void emitConstantPool(GlobalContext *Ctx);
325 }; 324 };
326 325
327 class TargetHeaderARM32 final : public TargetHeaderLowering { 326 class TargetHeaderARM32 final : public TargetHeaderLowering {
328 TargetHeaderARM32() = delete; 327 TargetHeaderARM32() = delete;
329 TargetHeaderARM32(const TargetHeaderARM32 &) = delete; 328 TargetHeaderARM32(const TargetHeaderARM32 &) = delete;
330 TargetHeaderARM32 &operator=(const TargetHeaderARM32 &) = delete; 329 TargetHeaderARM32 &operator=(const TargetHeaderARM32 &) = delete;
331 330
332 public: 331 public:
333 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) { 332 static std::unique_ptr<TargetHeaderLowering> create(GlobalContext *Ctx) {
334 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderARM32(Ctx)); 333 return std::unique_ptr<TargetHeaderLowering>(new TargetHeaderARM32(Ctx));
335 } 334 }
336 335
337 void lower() override; 336 void lower() override;
338 337
339 protected: 338 protected:
340 explicit TargetHeaderARM32(GlobalContext *Ctx); 339 explicit TargetHeaderARM32(GlobalContext *Ctx);
341 340
342 private: 341 private:
343 ~TargetHeaderARM32() = default; 342 ~TargetHeaderARM32() = default;
344 }; 343 };
345 344
346 } // end of namespace Ice 345 } // end of namespace Ice
347 346
348 #endif // SUBZERO_SRC_ICETARGETLOWERINGARM32_H 347 #endif // SUBZERO_SRC_ICETARGETLOWERINGARM32_H
OLDNEW
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698