Use ImageLoader instead of ImageLoadingTracker (Part 9)

Use ImageLoader instead of ImageLoadingTracker (Part 9)

BUG=163929
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178361

[rpaquay, 2013-01-14 23:11:12]

Use ImageLoader instead of ImageLoadingTracker (Part 9)

BUG=163929

[asargent_no_longer_on_chrome, 2013-01-15 00:17:23]

LGTM

[jianli, 2013-01-15 01:58:04]

https://codereview.chromium.org/11886029/diff/1/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel.cc (left):

https://codereview.chromium.org/11886029/diff/1/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel.cc:226: app_icon_loader_.reset();
Do we need to do the similar thing here by calling something like
InvalidateWeakPtrs?

[rpaquay, 2013-01-16 20:49:11]

Address code review feedback.

https://codereview.chromium.org/11886029/diff/1/chrome/browser/ui/panels/pane...
File chrome/browser/ui/panels/panel.cc (left):

https://codereview.chromium.org/11886029/diff/1/chrome/browser/ui/panels/pane...
chrome/browser/ui/panels/panel.cc:226: app_icon_loader_.reset();
On 2013/01/15 01:58:04, jianli wrote:
> Do we need to do the similar thing here by calling something like
> InvalidateWeakPtrs?
I believe you are correct. Fixed.

[jianli, 2013-01-16 23:58:12]

lgtm

[commit-bot: I haz the power, 2013-01-22 19:24:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11886029/7001

[commit-bot: I haz the power, 2013-01-22 20:23:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[rpaquay, 2013-01-22 22:39:47]

jianli@: FYI: Added "#include gfx/skia.h" to fix build error on chromeos/win.
This file used to be transitively included by image tracking loader.

[commit-bot: I haz the power, 2013-01-22 22:46:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11886029/7004

[commit-bot: I haz the power, 2013-01-23 01:47:39]

Failed to apply patch for chrome/browser/extensions/image_loading_tracker.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/image_loading_tracker.h
  Hunk #1 FAILED at 131.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/image_loading_tracker.h.rej

Patch:       chrome/browser/extensions/image_loading_tracker.h
Index: chrome/browser/extensions/image_loading_tracker.h
diff --git a/chrome/browser/extensions/image_loading_tracker.h
b/chrome/browser/extensions/image_loading_tracker.h
index
60a1178c9ab96367443974b1330d4e03e9c8a149..c0670add337776dc5e650d8f970f0433ea5e65d3
100644
--- a/chrome/browser/extensions/image_loading_tracker.h
+++ b/chrome/browser/extensions/image_loading_tracker.h
@@ -131,7 +131,6 @@ class ImageLoadingTracker : public
content::NotificationObserver {
   // usage of this class, so once this list is empty this class can and
   // should be removed.
   friend class ExtensionInfoBar;
-  friend class Panel;
   friend class ShellWindow;
   friend class extensions::IconImage;
   friend class extensions::TabHelper;

[commit-bot: I haz the power, 2013-01-23 17:52:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11886029/18004

[commit-bot: I haz the power, 2013-01-23 20:11:56]

Change committed as 178361