Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(308)

Issue 11886010: Merge 139282 (Closed)

Created:
7 years, 9 months ago by kerz_chromium
Modified:
7 years, 9 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139282 > Make caret repainting container-aware > https://bugs.webkit.org/show_bug.cgi?id=103955 > > Patch by Tien-Ren Chen <trchen@chromium.org>; on 2013-01-09 > Reviewed by Simon Fraser. > > Source/WebCore: > > Only invalidate local rects on the caret's repaint container, > instead of invalidating an absolute rect on the whole view. > > Test: fast/repaint/caret-with-transformation.html > > * editing/FrameSelection.cpp: > (WebCore::caretRendersInsideNode): > (WebCore::caretRenderer): > (WebCore::FrameSelection::caretRenderer): > (WebCore::DragCaretController::caretRenderer): > (WebCore::repaintCaretForLocalRect): > (WebCore::FrameSelection::recomputeCaretRect): > (WebCore::CaretBase::invalidateCaretRect): > (WebCore::FrameSelection::focusedOrActiveStateChanged): > * editing/FrameSelection.h: > * rendering/RenderView.cpp: > (WebCore::RenderView::repaintSelection): > * rendering/RenderView.h: > > LayoutTests: > > The caret repaint padding has been removed. Needs rebaseline. > Added test that carets should be repainted correctly on a transformed element. > > * fast/repaint/caret-with-transformation.html: Added. > * platform/chromium/TestExpectations: > * platform/mac/TestExpectations: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5664 lines, -49 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +2230 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/caret-with-transformation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +3374 lines, -0 lines 0 comments Download
M Source/WebCore/editing/FrameSelection.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/WebCore/editing/FrameSelection.cpp View 7 chunks +33 lines, -46 lines 0 comments Download
M Source/WebCore/rendering/RenderView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderView.cpp View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 9 months ago (2013-01-14 00:55:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698