Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: LayoutTests/imported/web-platform-tests/webrtc/simplecall.html

Issue 1188583004: update-w3c-deps import using blink 9d3793ee56e5bb1aa1eef078d848e1b0e6e4d355: (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/imported/web-platform-tests/webrtc/promises-call.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/imported/web-platform-tests/webrtc/simplecall.html
diff --git a/LayoutTests/imported/web-platform-tests/webrtc/simplecall.html b/LayoutTests/imported/web-platform-tests/webrtc/simplecall.html
index 595af80e95bc9b4717b443c6678c636ac37ebb38..71dcb682b749aeb7fa39fa93b02e9fff85fce4b5 100644
--- a/LayoutTests/imported/web-platform-tests/webrtc/simplecall.html
+++ b/LayoutTests/imported/web-platform-tests/webrtc/simplecall.html
@@ -38,7 +38,7 @@ instance --use-fake-device-for-media-stream for Chrome.
var gSecondConnection = null;
function getUserMediaOkCallback(localStream) {
- gFirstConnection = new RTCPeerConnection(null, null);
+ gFirstConnection = new RTCPeerConnection(null);
gFirstConnection.onicecandidate = onIceCandidateToFirst;
gFirstConnection.addStream(localStream);
gFirstConnection.createOffer(onOfferCreated, failed('createOffer'));
@@ -56,7 +56,7 @@ instance --use-fake-device-for-media-stream for Chrome.
});
function receiveCall(offerSdp) {
- gSecondConnection = new RTCPeerConnection(null, null);
+ gSecondConnection = new RTCPeerConnection(null);
gSecondConnection.onicecandidate = onIceCandidateToSecond;
gSecondConnection.onaddstream = onRemoteStream;
@@ -84,23 +84,18 @@ instance --use-fake-device-for-media-stream for Chrome.
test.done();
};
- // Note: the ice candidate handlers are special. We can not wrap them in test
- // steps since that seems to cause some kind of starvation that prevents the
- // call of being set up. Unfortunately we cannot report errors in here.
- var onIceCandidateToFirst = function(event) {
+ var onIceCandidateToFirst = test.step_func(function(event) {
// If event.candidate is null = no more candidates.
if (event.candidate) {
- var candidate = new RTCIceCandidate(event.candidate);
- gSecondConnection.addIceCandidate(candidate);
+ gSecondConnection.addIceCandidate(event.candidate);
}
- };
+ });
- var onIceCandidateToSecond = function(event) {
+ var onIceCandidateToSecond = test.step_func(function(event) {
if (event.candidate) {
- var candidate = new RTCIceCandidate(event.candidate);
- gFirstConnection.addIceCandidate(candidate);
+ gFirstConnection.addIceCandidate(event.candidate);
}
- };
+ });
var onRemoteStream = test.step_func(function(event) {
var videoTag = document.getElementById('remote-view');
« no previous file with comments | « LayoutTests/imported/web-platform-tests/webrtc/promises-call.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698