Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: LayoutTests/imported/web-platform-tests/README.md

Issue 1188583004: update-w3c-deps import using blink 9d3793ee56e5bb1aa1eef078d848e1b0e6e4d355: (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/imported/web-platform-tests/README.md
diff --git a/LayoutTests/imported/web-platform-tests/README.md b/LayoutTests/imported/web-platform-tests/README.md
index d88864a1f95ade9dd3419e6d3ec8bd3e34b20ec6..6dc0a2ad74729ab245b27319ce0f2041c1a56db2 100644
--- a/LayoutTests/imported/web-platform-tests/README.md
+++ b/LayoutTests/imported/web-platform-tests/README.md
@@ -172,18 +172,29 @@ The way to contribute is just as usual:
* Commit locally and push that to your repo.
* Send in a pull request based on the above.
-A lint is available to test for common mistakes in testcases. It can
-be run with:
+Lint tool
+---------
+
+We have a lint tool for catching common mistakes in test files. You
+can run it manually by starting the `lint` executable from the root of
+your local web-platform-tests working directory like this:
```
./lint
```
-in the root of the checkout. It is also run for every submitted pull
-request, and branches with lint errors will not get merged. In the
-unusual case that the lint is reporting an error for something that is
-essential to your test, there is a whitelist at
-`tools/lint/lint.whitelist` that may be updated.
+The lint tool is also run automatically for every submitted pull
+request, and reviewers will not merge branches with tests that have
+lint errors, so you must fix any errors the lint tool reports. For
+details on doing that, see the [lint-tool documentation][lint-tool].
+
+But in the unusual case of error reports for things essential to a
+certain test or that for other exceptional reasons shouldn't prevent
+a merge of a test, update and commit the `lint.whitelist` file in the
+web-platform-tests root directory to suppress the error reports. For
+details on doing that, see the [lint-tool documentation][lint-tool].
+
+[lint-tool]: https://github.com/w3c/web-platform-tests/blob/master/docs/lint-tool.md
Adding command-line scripts ("tools" subdirs)
---------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698