Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp

Issue 1188563005: Compute snap offsets (both repeat and element based) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compile issue Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp b/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..d1ed6079df5d9d3b4d09843781b5d6babde6e64a
--- /dev/null
+++ b/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
@@ -0,0 +1,263 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "SnapCoordinator.h"
+
+#include "core/dom/Document.h"
+#include "core/dom/Element.h"
+#include "core/frame/FrameView.h"
+#include "core/style/ComputedStyle.h"
+#include "core/testing/DummyPageHolder.h"
+#include "platform/scroll/ScrollTypes.h"
+
+#include <gtest/gtest.h>
+
+namespace blink {
+
+class SnapCoordinatorTest : public testing::Test {
+protected:
+ SnapCoordinatorTest()
+ : pageHolder(DummyPageHolder::create())
+ , document(pageHolder->document())
+ {
+ setHTML(
+ "<style>"
+ " ::-webkit-scrollbar { display: none;}"
+ " #snap-container {"
+ " height: 1000px;"
+ " width: 1000px;"
+ " overflow: scroll;"
+ " scroll-snap-type: mandatory;"
+ " }"
+ " #snap-element-fixed-position {"
+ " position: fixed;"
+ " }"
+ "</style>"
+ "<body>"
+ " <div id='snap-container'>"
+ " <div id='snap-element'></div>"
+ " <div id='intermediate'>"
+ " <div id='nested-snap-element'></div>"
+ " </div>"
+ " <div id='snap-element-fixed-position'></div>"
+ " <div style='width:2000px; height:2000px;'></div>"
+ " </div>"
+ "</body>");
+ layoutAndStyle();
esprehn 2015/12/01 18:31:12 document.updateLayout()
majidvp 2015/12/03 17:54:17 Done.
+ }
+
+ void setHTML(const char* htmlContent)
+ {
+ document.documentElement()->setInnerHTML(String::fromUTF8(htmlContent), ASSERT_NO_EXCEPTION);
esprehn 2015/12/01 18:31:12 you don't need to call fromUTF8
majidvp 2015/12/03 17:54:17 Done.
+ }
+
+ void layoutAndStyle()
+ {
+ document.view()->updateAllLifecyclePhases();
esprehn 2015/12/01 18:31:12 document.updateLayout(), you don't need this helpe
majidvp 2015/12/03 17:54:17 Done.
+ }
+
+ Element* snapContainer()
+ {
+ return document.getElementById("snap-container");
esprehn 2015/12/01 18:31:12 return a reference, your code assumes this is neve
majidvp 2015/12/03 17:54:17 Done.
+ }
+
+ SnapCoordinator& coordinator()
+ {
+ return *document.snapCoordinator();
+ }
+
+ Vector<double> snapOffsets(const Element& node, ScrollbarOrientation orientation)
+ {
+ return coordinator().snapOffsets(node, orientation);
+ }
+
+ OwnPtr<DummyPageHolder> pageHolder;
+ Document& document;
+ TrackExceptionState exceptionState;
+};
+
+TEST_F(SnapCoordinatorTest, ValidRepeat)
+{
+ snapContainer()->setAttribute("style", "scroll-snap-points-x: repeat(20%); scroll-snap-points-y: repeat(400px);", exceptionState);
esprehn 2015/12/01 18:31:12 styleAttr, you don't need the exceptionState, or y
majidvp 2015/12/03 17:54:17 Didn't know about styleAttr. Neat. Done.
+ layoutAndStyle();
+
+ {
+ Vector<double> actual = snapOffsets(*snapContainer(), HorizontalScrollbar);
+ EXPECT_EQ(5U, actual.size());
+ for (size_t i = 0; i < actual.size(); ++i)
+ EXPECT_EQ((i+1)*200, actual[i]);
+ }
+ {
+ Vector<double> actual = snapOffsets(*snapContainer(), VerticalScrollbar);
+ EXPECT_EQ(2U, actual.size());
+ EXPECT_EQ(400, actual[0]);
+ EXPECT_EQ(800, actual[1]);
+ }
+}
+
+TEST_F(SnapCoordinatorTest, EmptyRepeat)
+{
+ snapContainer()->setAttribute("style", "scroll-snap-points-x: none; scroll-snap-points-y: none;", exceptionState);
esprehn 2015/12/01 18:31:12 styleAttr
majidvp 2015/12/03 17:54:17 Done.
+ layoutAndStyle();
+
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), HorizontalScrollbar).size());
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), VerticalScrollbar).size());
+}
+
+TEST_F(SnapCoordinatorTest, ZeroAndNegativeRepeat)
+{
+ // These be rejected as an invalid repeat values thus no snap offset is created
+ snapContainer()->setAttribute("style", "scroll-snap-points-x: repeat(-1px); scroll-snap-points-y: repeat(0px);", exceptionState);
+ layoutAndStyle();
+
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), HorizontalScrollbar).size());
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), VerticalScrollbar).size());
+
+ // Calc values are not be rejected outright but instead clamped to 1px min repeat value
+ snapContainer()->setAttribute("style", "scroll-snap-points-x: repeat(calc(10px - 100%)); scroll-snap-points-y: repeat(calc(0px));", exceptionState);
+ layoutAndStyle();
+
+ EXPECT_EQ(1000U, snapOffsets(*snapContainer(), HorizontalScrollbar).size());
+ EXPECT_EQ(1000U, snapOffsets(*snapContainer(), VerticalScrollbar).size());
+}
+
+TEST_F(SnapCoordinatorTest, SimpleSnapElement)
+{
+ Element* snapElement = document.getElementById("snap-element");
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 10px 11px;", exceptionState);
+ layoutAndStyle();
+
+ EXPECT_EQ(10, snapOffsets(*snapContainer(), HorizontalScrollbar)[0]);
+ EXPECT_EQ(11, snapOffsets(*snapContainer(), VerticalScrollbar)[0]);
+
+ // Multiple coordinate and translates
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 20px 21px, 40px 41px; transform: translate(10px, 10px);", exceptionState);
+ layoutAndStyle();
+
+
+ Vector<double> result = snapOffsets(*snapContainer(), HorizontalScrollbar);
+ EXPECT_EQ(30, result[0]);
+ EXPECT_EQ(50, result[1]);
+ result = snapOffsets(*snapContainer(), VerticalScrollbar);
+ EXPECT_EQ(31, result[0]);
+ EXPECT_EQ(51, result[1]);
+}
+
+TEST_F(SnapCoordinatorTest, NestedSnapElement)
+{
+ Element* snapElement = document.getElementById("nested-snap-element");
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 20px 25px;", exceptionState);
+ layoutAndStyle();
+
+ EXPECT_EQ(20, snapOffsets(*snapContainer(), HorizontalScrollbar)[0]);
+ EXPECT_EQ(25, snapOffsets(*snapContainer(), VerticalScrollbar)[0]);
+}
+
+TEST_F(SnapCoordinatorTest, PositionFixedSnapElement)
+{
+ Element* snapElement = document.getElementById("snap-element-fixed-position");
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 1px 1px;", exceptionState);
+ layoutAndStyle();
+
+ // Position fixed elements are contained in document and not its immediate
+ // ancestor scroller. They cannot be a valid snap destination so they should
+ // not contribute snap points to their immediate snap container or document
+ // See: https://lists.w3.org/Archives/Public/www-style/2015Jun/0376.html
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), HorizontalScrollbar).size());
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), VerticalScrollbar).size());
+
+ Element* body = document.viewportDefiningElement();
+ EXPECT_EQ(0U, snapOffsets(*body, HorizontalScrollbar).size());
+ EXPECT_EQ(0U, snapOffsets(*body, VerticalScrollbar).size());
+}
+
+TEST_F(SnapCoordinatorTest, RepeatAndSnapElementTogether)
+{
+ document.getElementById("snap-element")->setAttribute("style", "scroll-snap-coordinate: 5px 10px;", exceptionState);
+ document.getElementById("nested-snap-element")->setAttribute("style", "scroll-snap-coordinate: 250px 450px;", exceptionState);
+
+ snapContainer()->setAttribute("style", "scroll-snap-points-x: repeat(20%); scroll-snap-points-y: repeat(400px);", exceptionState);
+ layoutAndStyle();
+
+ {
+ Vector<double> result = snapOffsets(*snapContainer(), HorizontalScrollbar);
+ EXPECT_EQ(7U, result.size());
+ EXPECT_EQ(5, result[0]);
+ EXPECT_EQ(200, result[1]);
+ EXPECT_EQ(250, result[2]);
+ }
+ {
+ Vector<double> result = snapOffsets(*snapContainer(), VerticalScrollbar);
+ EXPECT_EQ(4U, result.size());
+ EXPECT_EQ(10, result[0]);
+ EXPECT_EQ(400, result[1]);
+ EXPECT_EQ(450, result[2]);
+ }
+}
+
+TEST_F(SnapCoordinatorTest, SnapPointsAreScrollOffsetIndependent)
+{
+ Element* snapElement = document.getElementById("snap-element");
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 10px 11px;", exceptionState);
+ snapContainer()->scrollBy(100, 100);
+ layoutAndStyle();
+
+ EXPECT_EQ(snapContainer()->scrollLeft(), 100);
+ EXPECT_EQ(snapContainer()->scrollTop(), 100);
+ EXPECT_EQ(10, snapOffsets(*snapContainer(), HorizontalScrollbar)[0]);
+ EXPECT_EQ(11, snapOffsets(*snapContainer(), VerticalScrollbar)[0]);
+}
+
+TEST_F(SnapCoordinatorTest, UpdateStyleForSnapElement)
+{
+ Element* snapElement = document.getElementById("snap-element");
+ snapElement->setAttribute("style", "scroll-snap-coordinate: 10px 11px;", exceptionState);
+ layoutAndStyle();
+
+
+ EXPECT_EQ(10, snapOffsets(*snapContainer(), HorizontalScrollbar)[0]);
+ EXPECT_EQ(11, snapOffsets(*snapContainer(), VerticalScrollbar)[0]);
+
+ // Remove element
+ snapElement->parentNode()->removeChild(snapElement, exceptionState);
esprehn 2015/12/01 18:31:12 snapElement->remove()
majidvp 2015/12/03 17:54:17 Done.
+ layoutAndStyle();
+
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), HorizontalScrollbar).size());
+ EXPECT_EQ(0U, snapOffsets(*snapContainer(), VerticalScrollbar).size());
+
+ // add a new element
+ Element* container = document.getElementById("snap-container");
+ container->setInnerHTML(String::fromUTF8("<div style='scroll-snap-coordinate: 20px 22px;'><div style='width:2000px; height:2000px;'></div></div>"), ASSERT_NO_EXCEPTION);
esprehn 2015/12/01 18:31:12 no need to call fromUTF8, just do setInnerHTML("..
majidvp 2015/12/03 17:54:17 Done.
+ layoutAndStyle();
+
+ EXPECT_EQ(20, snapOffsets(*snapContainer(), HorizontalScrollbar)[0]);
+ EXPECT_EQ(22, snapOffsets(*snapContainer(), VerticalScrollbar)[0]);
+}
+
+TEST_F(SnapCoordinatorTest, DocumentWithSnapElement)
+{
+ setHTML(
+ "<body style='scroll-snap-type: mandatory; height:1000px; width:1000px; overflow:scroll;'>"
+ " <div id='snap-element' style='scroll-snap-coordinate: 5px 6px;'></div>"
+ " <div>"
+ " <div id='nested-snap-element' style='scroll-snap-coordinate: 10px 11px;'></div>"
+ " </div>"
+ " <div style='width:2000px; height:2000px;'></div>"
+ "</body>");
+
+ layoutAndStyle();
+
+ // we should be able to set snap points on the document element
+ Element* body = document.viewportDefiningElement();
+ Vector<double> result = snapOffsets(*body, HorizontalScrollbar);
+ EXPECT_EQ(5, result[0]);
+ EXPECT_EQ(10, result[1]);
+ result = snapOffsets(*body, VerticalScrollbar);
+ EXPECT_EQ(6, result[0]);
+ EXPECT_EQ(11, result[1]);
+}
+
+
+} // namespace
« third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698