Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/core/layout/LayoutObject.cpp

Issue 1188563005: Compute snap offsets (both repeat and element based) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clean up TODOs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 #include "core/layout/LayoutScrollbarPart.h" 68 #include "core/layout/LayoutScrollbarPart.h"
69 #include "core/layout/LayoutTableCaption.h" 69 #include "core/layout/LayoutTableCaption.h"
70 #include "core/layout/LayoutTableCell.h" 70 #include "core/layout/LayoutTableCell.h"
71 #include "core/layout/LayoutTableCol.h" 71 #include "core/layout/LayoutTableCol.h"
72 #include "core/layout/LayoutTableRow.h" 72 #include "core/layout/LayoutTableRow.h"
73 #include "core/layout/LayoutTheme.h" 73 #include "core/layout/LayoutTheme.h"
74 #include "core/layout/LayoutView.h" 74 #include "core/layout/LayoutView.h"
75 #include "core/layout/compositing/DeprecatedPaintLayerCompositor.h" 75 #include "core/layout/compositing/DeprecatedPaintLayerCompositor.h"
76 #include "core/page/AutoscrollController.h" 76 #include "core/page/AutoscrollController.h"
77 #include "core/page/Page.h" 77 #include "core/page/Page.h"
78 #include "core/page/scrolling/SnapCoordinator.h"
78 #include "core/paint/DeprecatedPaintLayer.h" 79 #include "core/paint/DeprecatedPaintLayer.h"
79 #include "core/paint/ObjectPainter.h" 80 #include "core/paint/ObjectPainter.h"
80 #include "core/style/ContentData.h" 81 #include "core/style/ContentData.h"
81 #include "core/style/ShadowList.h" 82 #include "core/style/ShadowList.h"
82 #include "platform/JSONValues.h" 83 #include "platform/JSONValues.h"
83 #include "platform/RuntimeEnabledFeatures.h" 84 #include "platform/RuntimeEnabledFeatures.h"
84 #include "platform/TraceEvent.h" 85 #include "platform/TraceEvent.h"
85 #include "platform/TracedValue.h" 86 #include "platform/TracedValue.h"
86 #include "platform/geometry/TransformState.h" 87 #include "platform/geometry/TransformState.h"
87 #include "platform/graphics/GraphicsContext.h" 88 #include "platform/graphics/GraphicsContext.h"
(...skipping 1870 matching lines...) Expand 10 before | Expand all | Expand 10 after
1958 1959
1959 if (oldStyle && !areCursorsEqual(oldStyle, style())) { 1960 if (oldStyle && !areCursorsEqual(oldStyle, style())) {
1960 if (LocalFrame* frame = this->frame()) { 1961 if (LocalFrame* frame = this->frame()) {
1961 // Cursor update scheduling is done by the local root, which is the main frame if there 1962 // Cursor update scheduling is done by the local root, which is the main frame if there
1962 // are no RemoteFrame ancestors in the frame tree. Use of localFrame Root() is 1963 // are no RemoteFrame ancestors in the frame tree. Use of localFrame Root() is
1963 // discouraged but will change when cursor update scheduling is move d from EventHandler 1964 // discouraged but will change when cursor update scheduling is move d from EventHandler
1964 // to PageEventHandler. 1965 // to PageEventHandler.
1965 frame->localFrameRoot()->eventHandler().scheduleCursorUpdate(); 1966 frame->localFrameRoot()->eventHandler().scheduleCursorUpdate();
1966 } 1967 }
1967 } 1968 }
1969
1970 if (SnapCoordinator* snapCoordinator = document().frame()->snapCoordinator() )
1971 snapCoordinator->styleChanged(node(), oldStyle);
esprehn 2015/09/24 17:37:41 This doesn't belong here, I think you want it in E
majidvp 2015/10/15 21:47:02 Done.
1968 } 1972 }
1969 1973
1970 void LayoutObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly) 1974 void LayoutObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly)
1971 { 1975 {
1972 // FIXME: We could save this call when the change only affected non-inherite d properties. 1976 // FIXME: We could save this call when the change only affected non-inherite d properties.
1973 for (LayoutObject* child = slowFirstChild(); child; child = child->nextSibli ng()) { 1977 for (LayoutObject* child = slowFirstChild(); child; child = child->nextSibli ng()) {
1974 if (!child->isAnonymous() || child->style()->styleType() != NOPSEUDO) 1978 if (!child->isAnonymous() || child->style()->styleType() != NOPSEUDO)
1975 continue; 1979 continue;
1976 1980
1977 if (blockChildrenOnly && !child->isLayoutBlock()) 1981 if (blockChildrenOnly && !child->isLayoutBlock())
(...skipping 1410 matching lines...) Expand 10 before | Expand all | Expand 10 after
3388 const blink::LayoutObject* root = object1; 3392 const blink::LayoutObject* root = object1;
3389 while (root->parent()) 3393 while (root->parent())
3390 root = root->parent(); 3394 root = root->parent();
3391 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3395 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3392 } else { 3396 } else {
3393 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3397 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3394 } 3398 }
3395 } 3399 }
3396 3400
3397 #endif 3401 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698