Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1188513005: Move CSSParserString out of CSSParserValues.h (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move CSSParserString out of CSSParserValues.h Move CSSParserString out of CSSParserValues.h since CSSParserValues.h is scheduled for removal. Also adjust the various includes. BUG=499780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197150

Patch Set 1 #

Patch Set 2 : Change includes to use CSSParserString.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -80 lines) Patch
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A Source/core/css/parser/CSSParserString.h View 1 chunk +105 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserToken.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 chunk +1 line, -76 lines 0 comments Download
M Source/core/css/parser/CSSTokenizer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSTokenizerInputStream.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 6 months ago (2015-06-15 17:05:58 UTC) #2
Timothy Loh
On 2015/06/15 17:05:58, rwlbuis wrote: > PTAL lgtm
5 years, 6 months ago (2015-06-15 23:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188513005/20001
5 years, 6 months ago (2015-06-16 00:17:35 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 01:16:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197150

Powered by Google App Engine
This is Rietveld 408576698