chromeos/chromeos_tools.gypi - Issue 11885046: Adding a separate ONC validation binary.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/chromeos_tools.gypi

Issue 11885046: Adding a separate ONC validation binary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a description of the exist status. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
	oshima 2013/01/23 19:24:38 2013 2013 pneubeck (no reviews) 2013/01/24 13:35:02 Done. Show quoted text On 2013/01/23 19:24:38, oshima wrote: > 2013 Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'variables': {

	7 'chromium_code': 1,

	8 },
	oshima 2013/01/23 19:24:38 do you need this? do you need this? pneubeck (no reviews) 2013/01/23 21:24:47 At first I copied this from another gypi and then Show quoted text On 2013/01/23 19:24:38, oshima wrote: > do you need this? At first I copied this from another gypi and then checked the documentation in build/common.gypi and guessed that it should be right to set it. Looking at it again, shouldn't the variable be set per target? How can I correctly decide if that flag is needed? oshima 2013/01/23 23:16:17 This is already set in chromeos.gyp, you probably Show quoted text On 2013/01/23 21:24:47, pneubeck wrote: > On 2013/01/23 19:24:38, oshima wrote: > > do you need this? > > At first I copied this from another gypi and then checked the documentation in > build/common.gypi and guessed that it should be right to set it. > > Looking at it again, shouldn't the variable be set per target? > How can I correctly decide if that flag is needed? This is already set in chromeos.gyp, you probably don't need this, unless you have specific reason to do so. pneubeck (no reviews) 2013/01/24 13:35:02 Done. Show quoted text On 2013/01/23 23:16:17, oshima wrote: > On 2013/01/23 21:24:47, pneubeck wrote: > > On 2013/01/23 19:24:38, oshima wrote: > > > do you need this? > > > > At first I copied this from another gypi and then checked the documentation in > > build/common.gypi and guessed that it should be right to set it. > > > > Looking at it again, shouldn't the variable be set per target? > > How can I correctly decide if that flag is needed? > > This is already set in chromeos.gyp, you probably don't need this, unless you > have specific reason to do so. Done.
	9 'targets' : [

	10 {

	11 'target_name': 'onc_validator',

	12 'type': 'executable',

	13 'dependencies': [

	14 '../base/base.gyp:base',

	15 'chromeos.gyp:chromeos',

	16 ],

	17 'sources': [

	18 'tools/onc_validator/onc_validator.cc',

	19 ],

	20 },

	21 ],

	22 }

OLD	NEW

« no previous file with comments | « chromeos/chromeos.gyp ('k') | chromeos/tools/onc_validator/OWNERS » ('j') | chromeos/tools/onc_validator/onc_validator.cc » ('J')