Fix selector name check, and make the interceptor participate in speculatively propagating types.

sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	(revision 17051)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	(working copy)
@@ -1355,7 +1355,7 @@
       return HType.UNKNOWN;
     } else if (selector.kind == SelectorKind.OPERATOR) {
       HType propagatedType = types[this];
-      if (selector.name == const SourceString('-') && input == inputs[1]) {
+      if (selector.name == const SourceString('unary-') && input == inputs[1]) {
         // If the outgoing type should be a number (integer, double or both) we
         // want the outgoing type to be the input too.
         // If we don't know the outgoing type we try to make it a number.
@@ -1378,7 +1378,7 @@
     if (!isInterceptorCall) return HType.UNKNOWN;
 
     if (selector.kind == SelectorKind.OPERATOR) {
-      if (selector.name == const SourceString('-')) {
+      if (selector.name == const SourceString('unary-')) {
         HType operandType = types[inputs[1]];
         if (operandType.isNumber()) return operandType;
       } else if (selector.name == const SourceString('~')) {
@@ -2403,6 +2403,24 @@
     setUseGvn();
   }
 
+  HType computeDesiredTypeForInput(HInstruction input,
+                                   HTypeMap types,
+                                   Compiler compiler) {

[ngeoffray, 2013/01/15 10:32:27]

This was the main reason for the unit test to fail: the unit test was looking
for a type guard, but since the interceptor did not say the type it wanted, the
type guard was not inserted. Before, a "-a" in Dart code that translates to the
SSA HNegate was always saying it wanted a number as input.

+    if (interceptedClasses.length != 1) return HType.UNKNOWN;
+    // If the only class being intercepted is of type number, we
+    // make this interceptor call say it wants that class as input.
+    Element interceptor = interceptedClasses.toList()[0];
+    JavaScriptBackend backend = compiler.backend;
+    if (interceptor == backend.jsNumberClass) {
+      return HType.NUMBER;
+    } else if (interceptor == backend.jsIntClass) {
+      return HType.INTEGER;
+    } else if (interceptor == backend.jsDoubleClass) {
+      return HType.DOUBLE;
+    }
+    return HType.UNKNOWN;
+  }
+
   int typeCode() => HInstruction.INTERCEPTOR_TYPECODE;
   bool typeEquals(other) => other is HInterceptor;
   bool dataEquals(HInterceptor other) {