Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1188503003: [turbofan] The AstGraphBuilder does not need to care about types. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The AstGraphBuilder does not need to care about types. AstGraphBuilder::BuildToBoolean() can be optimized easily without types, especially since the types are only present on some nodes during graph building. So this optimization is both more efficient and more effective at the same time. We will probably refactor this code into a separate optimization method/class later. R=jarin@chromium.org Committed: https://crrev.com/f1db38cae07f873e21ac57d2ff0cdc57134906c9 Cr-Commit-Position: refs/heads/master@{#29062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +16 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-17 05:05:53 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-06-17 05:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188503003/1
5 years, 6 months ago (2015-06-17 05:10:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 05:43:21 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 05:43:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1db38cae07f873e21ac57d2ff0cdc57134906c9
Cr-Commit-Position: refs/heads/master@{#29062}

Powered by Google App Engine
This is Rietveld 408576698