Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 11885019: Removed deprecated functions from v8's external API. (Closed)

Created:
7 years, 11 months ago by Sven Panne
Modified:
7 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Removed deprecated functions from v8's external API. Removed the following deprecated functions: * Object::GetPointerFromInternalField * Object::SetPointerInInternalField * External::Wrap * External::Unwrap * Context::GetData * Context::SetData They have been deprecated in the 3.15 branch and are not used by Chrome anymore. Furthermore, judging from bug reports and email threads, embedders like node.js and others are already using 3.15, too. All removed API entries can be emulated by a one-liner, so adapting should not be hard for anybody. We want to introduce more deprecations soon, but to keep things simple and avoid having old and not-so-old deprecations in v8.h, the 3.15 deprecations are now removed. In general, the strategy of keeping deprecated things for one stable release and then removing them seems to be a good compromise between a maintenance nightmare and annoying external embedders. :-) Committed: http://code.google.com/p/v8/source/detail?r=13372

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -173 lines) Patch
M include/v8.h View 6 chunks +0 lines, -58 lines 0 comments Download
M src/api.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 13 chunks +21 lines, -93 lines 0 comments Download
M test/cctest/test-debug.cc View 5 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
7 years, 11 months ago (2013-01-14 13:13:57 UTC) #1
Michael Starzinger
7 years, 11 months ago (2013-01-14 13:36:39 UTC) #2
LGTM. Let's hope we are not breaking the world with this.

Powered by Google App Engine
This is Rietveld 408576698