runtime/vm/compiler.cc - Issue 11885017: Canonicalize away redundant checks that appear after store-to-load forwarding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 11885017: Canonicalize away redundant checks that appear after store-to-load forwarding. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase, change test status Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index 406802556d4ad3826947b4c71bf670efdf8b7d37..0931e8fb23a9d615cd76960b100253032ee7d82f 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -246,6 +246,9 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,

optimizer.InferSmiRanges();

}

+ // The final canonicalization pass before the code generation.

+ optimizer.Canonicalize();

// Perform register allocation on the SSA graph.

FlowGraphAllocator allocator(*flow_graph);

allocator.AllocateRegisters();

« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »