Issue 11885015: Merge 165503

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11885015: Merge 165503 (Closed)

Created:
7 years, 11 months ago by Yusuke Sato

Modified:
7 years, 11 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

More Reviews

Description

Merge 165503 > Allow Caps Lock to be remapped [part 2 of 2]. > > * Add a new Chrome command line flag: --has-chromeos-keyboard > * Show the new UI for remapping Caps Lock if --has-chromeos-keyboard is not specified. > > This CL depends on http://codereview.chromium.org/11314020/ and https://gerrit.chromium.org/gerrit/#/c/36884/. > > BUG=146204 > TEST=manually confirmed that 1) the new UI is shown when /etc/session_manager_use_flags.txt does not have "chromeos_keyboard", is not shown when the file has the flag, 2) the UI for guest mode is the same as non-guest mode, 3) the UI correctly remaps the Caps Lock key. > > Review URL: https://chromiumcodereview.appspot.com/11346028 BUG=chromium-os-partner:14985 TBR=yusukes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176516

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+169 lines, -31 lines)			Patch
M	chrome/browser/chromeos/login/login_utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/keyboard_overlay.html	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/keyboard_overlay.js	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/event_rewriter.cc	View	5 chunks	+49 lines, -27 lines	0 comments	Download
M	chrome/browser/ui/ash/event_rewriter_unittest.cc	View	3 chunks	+80 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/keyboard_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages