Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: net/proxy/proxy_resolver_error_observer.h

Issue 11885009: Improve performance of proxy resolver by tracing DNS dependencies. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: re-upload due to failure last time Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver.h ('k') | net/proxy/proxy_resolver_js_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_error_observer.h
diff --git a/net/proxy/proxy_resolver_error_observer.h b/net/proxy/proxy_resolver_error_observer.h
index 9176c2f233fb579a80aece21b211898232decee5..6ee9cbba1bb8dfed49a477a1dafbf7535d563ad8 100644
--- a/net/proxy/proxy_resolver_error_observer.h
+++ b/net/proxy/proxy_resolver_error_observer.h
@@ -11,10 +11,7 @@
namespace net {
-// Interface for observing JavaScript error messages from PAC scripts. The
-// default implementation of the ProxyResolverJSBindings takes a class
-// implementing this interface and forwards all JavaScript errors related to
-// PAC scripts.
+// Interface for observing JavaScript error messages from PAC scripts.
class NET_EXPORT_PRIVATE ProxyResolverErrorObserver {
public:
ProxyResolverErrorObserver() {}
@@ -23,6 +20,11 @@ class NET_EXPORT_PRIVATE ProxyResolverErrorObserver {
// Handler for when an error is encountered. |line_number| may be -1
// if a line number is not applicable to this error. |error| is a message
// describing the error.
+ //
+ // Note on threading: This may get called from a worker thread. If the
+ // backing proxy resolver is ProxyResolverV8Tracing, then it will not
+ // be called concurrently, however it will be called from a different
+ // thread than the proxy resolver's origin thread.
virtual void OnPACScriptError(int line_number, const string16& error) = 0;
private:
« no previous file with comments | « net/proxy/proxy_resolver.h ('k') | net/proxy/proxy_resolver_js_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698