Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: src/compiler/graph-reducer.cc

Issue 1188433010: [turbofan] Move graph trimming functionality to dedicated GraphTrimmer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph-reducer.h ('k') | src/compiler/graph-trimmer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-reducer.cc
diff --git a/src/compiler/graph-reducer.cc b/src/compiler/graph-reducer.cc
index 5435fb072c6da4b7f81db9a77c2eddf8bac1c96f..33d400b61e1a736505b3a67111ff7f1187e05ef5 100644
--- a/src/compiler/graph-reducer.cc
+++ b/src/compiler/graph-reducer.cc
@@ -14,9 +14,6 @@ namespace v8 {
namespace internal {
namespace compiler {
-bool Reducer::Finish() { return true; }
-
-
enum class GraphReducer::State : uint8_t {
kUnvisited,
kRevisit,
@@ -70,23 +67,7 @@ void GraphReducer::ReduceNode(Node* node) {
}
-void GraphReducer::ReduceGraph() {
- for (;;) {
- ReduceNode(graph()->end());
- // TODO(turbofan): Remove this once the dead node trimming is in the
- // GraphReducer.
- bool done = true;
- for (Reducer* const reducer : reducers_) {
- if (!reducer->Finish()) {
- done = false;
- break;
- }
- }
- if (done) break;
- // Reset all marks on the graph in preparation to re-reduce the graph.
- state_.Reset(graph());
- }
-}
+void GraphReducer::ReduceGraph() { ReduceNode(graph()->end()); }
Reduction GraphReducer::Reduce(Node* const node) {
« no previous file with comments | « src/compiler/graph-reducer.h ('k') | src/compiler/graph-trimmer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698