Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1188433010: [turbofan] Move graph trimming functionality to dedicated GraphTrimmer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move graph trimming functionality to dedicated GraphTrimmer. Up until now that was still mixed with control reduction in the ControlReducer. This separation allows us to remove the horrible Reducer::Finish hack and also do graph trimming at more appropriate places in the pipeline (i.e. trim dead nodes after generic lowering, which can also make nodes dead). R=jarin@chromium.org,mstarzinger@chromium.org Committed: https://crrev.com/80a6e53935a8205f0b5032759ecdf8aecb8d2a38 Cr-Commit-Position: refs/heads/master@{#29077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -356 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/control-reducer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +0 lines, -103 lines 0 comments Download
M src/compiler/graph-reducer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +1 line, -20 lines 0 comments Download
A src/compiler/graph-trimmer.h View 1 chunk +57 lines, -0 lines 0 comments Download
A src/compiler/graph-trimmer.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M src/compiler/node-marker.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/node-marker.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/osr.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +30 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 2 chunks +0 lines, -209 lines 0 comments Download
A test/unittests/compiler/graph-trimmer-unittest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-17 09:28:48 UTC) #1
Benedikt Meurer
Hey Michi, Jaro, This separates the control reduction from the dead node trimming. There's no ...
5 years, 6 months ago (2015-06-17 09:30:05 UTC) #2
Jarin
lgtm. very nice.
5 years, 6 months ago (2015-06-17 09:41:03 UTC) #3
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-17 10:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188433010/1
5 years, 6 months ago (2015-06-17 10:33:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 10:56:35 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 10:56:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80a6e53935a8205f0b5032759ecdf8aecb8d2a38
Cr-Commit-Position: refs/heads/master@{#29077}

Powered by Google App Engine
This is Rietveld 408576698