Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 11884049: Merge 139151 (Closed)

Created:
7 years, 9 months ago by tkent
Modified:
7 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139151 > REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value="" > https://bugs.webkit.org/show_bug.cgi?id=106284 > > Reviewed by Hajime Morita. > > Source/WebCore: > > No new tests. Updates fast/forms/number/number/validity-badinput.html. > > * html/NumberInputType.cpp: > (WebCore::NumberInputType::setValue): > If the new sanitized value is empty and innerTextValue is a bad input > (it means !valueChanged && !innerTextValue().isEmpty() because the new > sanitized value is empty), we need to update innerTextValue with the > empty string. > * html/NumberInputType.h: > (NumberInputType): Declare setValue. > > LayoutTests: > > * fast/forms/number/number-validity-badinput.html: > Add a test case. > * fast/forms/number/number-validity-badinput-expected.txt: > TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M LayoutTests/fast/forms/number/number-validity-badinput.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/number/number-validity-badinput-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/html/NumberInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/html/NumberInputType.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
7 years, 9 months ago (2013-01-15 07:43:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698