InstantExtended: Bail on TemplateURLs with no espv.

chrome/browser/search_engines/template_url.h

Index: chrome/browser/search_engines/template_url.h
diff --git a/chrome/browser/search_engines/template_url.h b/chrome/browser/search_engines/template_url.h
index 9660347e8af2abcf197751d06a17b1e45b839000..e9f8979246ae491c58411ce5230227eaca6fa86a 100644
--- a/chrome/browser/search_engines/template_url.h
+++ b/chrome/browser/search_engines/template_url.h
@@ -136,6 +136,10 @@ class TemplateURLRef {
   // {google:baseURL} or {google:baseSuggestURL}.
   bool HasGoogleBaseURLs() const;
 
+  // Returns true if this TemplateURLRef has a replacement term of
+  // {google:instantExtendedEnabledParameter}.
+  bool HasGoogleInstantExtendedParam() const;

[beaudoin, 2013/01/15 00:34:55]

In the current case you should be able to use
TemplateURLData::search_terms_replacement_key instead of a Google-specific
method. You can probably do something similar to
TemplateURL::HasSearchTermsReplacementKey instead of wrapping out your own.

[Jered, 2013/01/15 19:06:28]

I'm confused. Should supporting search terms replacement be equivalent with
supporting Instant extended? I really want to know if this URL supports the
param that tells the server that Instant Extended should be enabled.

[dhollowa, 2013/01/15 19:18:55]

Yes, this conflation of the two notions of instant-extended-support versus
search-term-replacement is becoming increasingly problematic.  IOS does the
latter but not the former, and my site-isolation work relies on the form but
uses the 'espv' mechanism to signal the former, but is labelled in code as the
latter.

+
   // Use the pattern referred to by this TemplateURLRef to match the provided
   // |url| and extract |search_terms| from it. Returns true if the pattern
   // matches, even if |search_terms| is empty. Returns false and an empty
@@ -453,6 +457,10 @@ class TemplateURL {
   // update the keyword to reflect the current Google base URL TLD.
   bool IsGoogleSearchURLWithReplaceableKeyword() const;
 
+  // Returns true if the instant_url for this TemplateURL has a replacement for
+  // enabling Instant Extended.
+  bool SupportsInstantExtendedParam() const;
+
   // Returns true if the keywords match or if
   // IsGoogleSearchURLWithReplaceableKeyword() is true for both TemplateURLs.
   bool HasSameKeywordAs(const TemplateURL& other) const;