Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 11884021: size_t -> uint32 for building on win x64 (Closed)

Created:
7 years, 11 months ago by scottmg
Modified:
7 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

size_t fixes for building on win x64 Fixes C4267 warnings, and errors regarding passing size_t* when they chould be unsigned int *. winrt_utils: WindowsCreateString takes a UINT32 as size. Truncation would mean shorter than expected string, but presumably not a severe problem in this case. file_picker: The interface uses unsigned int, not size_t, so change implementation and callers to unsigned int. R=cpu@chromium.org BUG=166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176854

Patch Set 1 #

Patch Set 2 : and file_picker too #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : e_invalidarg -> e_unexpected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M win8/metro_driver/file_picker.cc View 1 2 3 4 chunks +6 lines, -4 lines 0 comments Download
M win8/metro_driver/winrt_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years, 11 months ago (2013-01-14 18:28:39 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/11884021/diff/6001/win8/metro_driver/file_picker.cc File win8/metro_driver/file_picker.cc (right): https://codereview.chromium.org/11884021/diff/6001/win8/metro_driver/file_picker.cc#newcode49 win8/metro_driver/file_picker.cc:49: return E_INVALIDARG; return E_UNEXPECTED;
7 years, 11 months ago (2013-01-14 22:21:19 UTC) #2
scottmg
https://codereview.chromium.org/11884021/diff/6001/win8/metro_driver/file_picker.cc File win8/metro_driver/file_picker.cc (right): https://codereview.chromium.org/11884021/diff/6001/win8/metro_driver/file_picker.cc#newcode49 win8/metro_driver/file_picker.cc:49: return E_INVALIDARG; On 2013/01/14 22:21:20, cpu wrote: > return ...
7 years, 11 months ago (2013-01-14 22:27:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11884021/10001
7 years, 11 months ago (2013-01-14 22:39:56 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 08:40:58 UTC) #5
Message was sent while issue was closed.
Change committed as 176854

Powered by Google App Engine
This is Rietveld 408576698