Enable array index clamping in shader translator.

gpu/command_buffer/service/shader_translator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/shader_translator.h"
 
 #include <string.h>
 #include <algorithm>
 
 #include "base/at_exit.h"
@@ skipping 109 matching lines @@
 }
 
 bool ShaderTranslator::Translate(const char* shader) {
   // Make sure this instance is initialized.
   DCHECK(compiler_ != NULL);
   DCHECK(shader != NULL);
   ClearResults();
 
   bool success = false;
   int compile_options =
-      SH_OBJECT_CODE | SH_ATTRIBUTES_UNIFORMS | SH_MAP_LONG_VARIABLE_NAMES;
+      SH_OBJECT_CODE | SH_ATTRIBUTES_UNIFORMS |
+      SH_MAP_LONG_VARIABLE_NAMES | SH_CLAMP_INDIRECT_ARRAY_BOUNDS;

[greggman, 2013/01/12 01:31:37]

Do you want | SH_ENFORCE_PACKING_RESTRICTIONS
or no? Without that the clamping seems useless.

PS: I'm also kind curious why the ANGLE patch uses a function instead of
clamp(v, 0, array_size);

   if (needs_built_in_function_emulation_)
     compile_options |= SH_EMULATE_BUILT_IN_FUNCTIONS;
   if (ShCompile(compiler_, &shader, 1, compile_options)) {
     success = true;
     // Get translated shader.
     int obj_code_len = 0;
     ShGetInfo(compiler_, SH_OBJECT_CODE_LENGTH, &obj_code_len);
     if (obj_code_len > 1) {
       translated_shader_.reset(new char[obj_code_len]);
       ShGetObjectCode(compiler_, translated_shader_.get());
@@ skipping 56 matching lines @@
 void ShaderTranslator::ClearResults() {
   translated_shader_.reset();
   info_log_.reset();
   attrib_map_.clear();
   uniform_map_.clear();
 }
 
 }  // namespace gles2
 }  // namespace gpu