Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: Source/core/paint/DeprecatedPaintLayerStackingNode.h

Issue 1188363002: Compute the normal flow list on the fly (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix reverse iterator (OOPS). Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/DeprecatedPaintLayerStackingNode.h
diff --git a/Source/core/paint/DeprecatedPaintLayerStackingNode.h b/Source/core/paint/DeprecatedPaintLayerStackingNode.h
index 8a9bab8a7dc437fb6886f95718102ac83fd35fb2..022d98920b9b6465e32047e06351e52ffc824bcd 100644
--- a/Source/core/paint/DeprecatedPaintLayerStackingNode.h
+++ b/Source/core/paint/DeprecatedPaintLayerStackingNode.h
@@ -80,12 +80,8 @@ public:
bool hasPositiveZOrderList() const { return posZOrderList() && posZOrderList()->size(); }
bool hasNegativeZOrderList() const { return negZOrderList() && negZOrderList()->size(); }
- // FIXME: should check for dirtiness here?
- bool isNormalFlowOnly() const { return !isTreatedAsStackingContextForPainting(); }
bool isTreatedAsStackingContextForPainting() const { return m_isTreatedAsStackingContextForPainting; }
void updateIsTreatedAsStackingContextForPainting();
- bool normalFlowListDirty() const { return m_normalFlowListDirty; }
- void dirtyNormalFlowList();
void updateStackingNodesAfterStyleChange(const ComputedStyle* oldStyle);
@@ -110,12 +106,6 @@ private:
return m_posZOrderList.get();
}
- Vector<DeprecatedPaintLayerStackingNode*>* normalFlowList() const
- {
- ASSERT(!m_normalFlowListDirty);
- return m_normalFlowList.get();
- }
-
Vector<DeprecatedPaintLayerStackingNode*>* negZOrderList() const
{
ASSERT(!m_zOrderListsDirty);
@@ -128,16 +118,12 @@ private:
#if ENABLE(ASSERT)
bool isInStackingParentZOrderLists() const;
- bool isInStackingParentNormalFlowList() const;
void updateStackingParentForZOrderLists(DeprecatedPaintLayerStackingNode* stackingParent);
- void updateStackingParentForNormalFlowList(DeprecatedPaintLayerStackingNode* stackingParent);
void setStackingParent(DeprecatedPaintLayerStackingNode* stackingParent) { m_stackingParent = stackingParent; }
#endif
bool shouldBeTreatedAsStackingContextForPainting() const { return layoutObject()->style()->isTreatedAsStackingContextForPainting(); }
- void updateNormalFlowList();
-
bool isDirtyStackingContext() const { return m_zOrderListsDirty && isStackingContext(); }
DeprecatedPaintLayerCompositor* compositor() const;
@@ -153,11 +139,7 @@ private:
OwnPtr<Vector<DeprecatedPaintLayerStackingNode*>> m_posZOrderList;
OwnPtr<Vector<DeprecatedPaintLayerStackingNode*>> m_negZOrderList;
- // This list contains child nodes that cannot create stacking contexts.
- OwnPtr<Vector<DeprecatedPaintLayerStackingNode*>> m_normalFlowList;
-
unsigned m_zOrderListsDirty : 1;
- unsigned m_normalFlowListDirty: 1;
unsigned m_isTreatedAsStackingContextForPainting : 1;
#if ENABLE(ASSERT)

Powered by Google App Engine
This is Rietveld 408576698