src/api.cc - Issue 1188313006: Version 4.4.63.8 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1188313006: Version 4.4.63.8 (cherry-pick) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@4.4

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index daaaf765e236cf28e4e66cb0fbbd16a3334ca49f..01441351c5ad086d1e43feb63b8ff1924e7d00cb 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -6258,7 +6258,8 @@ v8::ArrayBuffer::Contents v8::ArrayBuffer::Externalize() {

Utils::ApiCheck(!self->is_external(), "v8::ArrayBuffer::Externalize",

"ArrayBuffer already externalized");

self->set_is_external(true);

- isolate->heap()->UnregisterArrayBuffer(self->backing_store());

+ isolate->heap()->UnregisterArrayBuffer(isolate->heap()->InNewSpace(*self),

+ self->backing_store());

return GetContents();

}

« no previous file with comments | « include/v8-version.h ('k') | src/heap/heap.h » ('j') | no next file with comments »