Revert 176773

Revert 176773
> Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.
> 
> BUG=168169
> TEST=should all pass
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175489
> 
> Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=175491
> 
> Review URL: https://chromiumcodereview.appspot.com/11788005

TBR=avi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176920

[Avi (use Gerrit), 2013-01-15 17:04:31]

What went wrong this time? Please provide links/data.

[kerz_chromium, 2013-01-15 17:06:59]

It broke Clank builds.  This is only reverted on the 1384 minibranch.


On Tue, Jan 15, 2013 at 9:04 AM, <avi@chromium.org> wrote:

> What went wrong this time? Please provide links/data.
>
>
https://codereview.chromium.**org/11883037/<https://codereview.chromium.org/1...
>

[Avi (use Gerrit), 2013-01-15 17:14:28]

It's a Clank patch, so where it broke isn't a surprise. Can you send the
link of the failure? Did it only break on 1384, or on trunk?


On Tue, Jan 15, 2013 at 12:06 PM, Jason Kersey <kerz@chromium.org> wrote:

> It broke Clank builds.  This is only reverted on the 1384 minibranch.
>
>
> On Tue, Jan 15, 2013 at 9:04 AM, <avi@chromium.org> wrote:
>
>> What went wrong this time? Please provide links/data.
>>
>>
https://codereview.chromium.**org/11883037/<https://codereview.chromium.org/1...
>>
>
>

[kerz_chromium, 2013-01-15 17:19:09]

It broke anyone trying to use Chromium tip of tree + Clank tip of tree,
which the official build tries to do.  We haven't had a build in a week
now, which is why I reverted this on the minibranch, so we can try to get
one.

Couple places to look:

Clankium builder:
http://clankbotmaster:8122/builders/instrumentation-yakju-clankium-tot/builds...

Official builder:
http://master.chrome.corp.google.com:8000/builders/android/builds/690




On Tue, Jan 15, 2013 at 9:14 AM, Avi Drissman <avi@chromium.org> wrote:

> It's a Clank patch, so where it broke isn't a surprise. Can you send the
> link of the failure? Did it only break on 1384, or on trunk?
>
>
> On Tue, Jan 15, 2013 at 12:06 PM, Jason Kersey <kerz@chromium.org> wrote:
>
>> It broke Clank builds.  This is only reverted on the 1384 minibranch.
>>
>>
>> On Tue, Jan 15, 2013 at 9:04 AM, <avi@chromium.org> wrote:
>>
>>> What went wrong this time? Please provide links/data.
>>>
>>>
https://codereview.chromium.**org/11883037/<https://codereview.chromium.org/1...
>>>
>>
>>
>

[boliu, 2013-01-15 19:34:01]

fyi, this has been fixed on clank trunk
https://gerrit-int.chromium.org/#/c/31120/

[kerz_chromium, 2013-01-15 19:37:07]

Great, thanks.  We'll pick that up for tomorrow's build.


On Tue, Jan 15, 2013 at 11:34 AM, <boliu@chromium.org> wrote:

> fyi, this has been fixed on clank trunk
>
https://gerrit-int.chromium.**org/#/c/31120/<https://gerrit-int.chromium.org/...
>
>
https://codereview.chromium.**org/11883037/<https://codereview.chromium.org/1...
>

[Avi (use Gerrit), 2013-01-15 20:22:07]

Awesome, thank you for your help.