Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1188303002: Fix a typo in Dialog (Closed)

Created:
5 years, 6 months ago by hansmuller1
Modified:
5 years, 6 months ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix a typo in Dialog If action: was specified, content: was added twice. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/dee826e3b762a1a393bcc3f9ff6c76203989832e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M sky/sdk/lib/widgets/dialog.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/widgets/dialog.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/tests/widgets/dialog-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hansmuller
PTAL
5 years, 6 months ago (2015-06-17 15:57:05 UTC) #3
jackson
lgtm
5 years, 6 months ago (2015-06-17 16:58:18 UTC) #5
hansmuller1
5 years, 6 months ago (2015-06-17 17:06:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dee826e3b762a1a393bcc3f9ff6c76203989832e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698