Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: tests/html/exceptions_test.dart

Issue 11883025: Detect if webkitNotifications is available and remove webkit prefix (replaced (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/html/exceptions_test.dart
diff --git a/tests/html/exceptions_test.dart b/tests/html/exceptions_test.dart
index 01fcd7c078a930565c0fc523bcd53a8d602fd7a4..222e3553651aac92f42a71b6e1220838733ca3f4 100644
--- a/tests/html/exceptions_test.dart
+++ b/tests/html/exceptions_test.dart
@@ -1,28 +1,40 @@
library ExceptionsTest;
import '../../pkg/unittest/lib/unittest.dart';
-import '../../pkg/unittest/lib/html_config.dart';
+import '../../pkg/unittest/lib/html_individual_config.dart';
import 'dart:html';
main() {
- useHtmlConfiguration();
- test('DomException', () {
- try {
- window.webkitNotifications.createNotification('', '', '');
- } on DomException catch (e) {
- expect(e.code, DomException.SECURITY_ERR);
- expect(e.name, 'SecurityError');
- expect(e.message, 'SecurityError: DOM Exception 18');
- }
+ useHtmlIndividualConfiguration();
+
+ group('supported', () {
+ test('supported', () {
+ expect(NotificationCenter.supported, true);
blois 2013/01/15 01:31:56 This should probably go in a separate notification
Emily Fortuna 2013/01/15 02:21:06 Done.
+ });
});
- test('EventException', () {
- final event = new Event('Event');
- // Intentionally do not initialize it!
- try {
- document.$dom_dispatchEvent(event);
- } on EventException catch (e) {
- expect(e.code, EventException.UNSPECIFIED_EVENT_TYPE_ERR);
- expect(e.name, 'UNSPECIFIED_EVENT_TYPE_ERR');
- expect(e.message, 'UNSPECIFIED_EVENT_TYPE_ERR: DOM Events Exception 0');
+
+ group('webkitNotifications', () {
+ if (NotificationCenter.supported) {
+ test('DomException', () {
+ try {
+ window.notifications.createNotification('', '', '');
+ } on DomException catch (e) {
+ expect(e.code, DomException.SECURITY_ERR);
+ expect(e.name, 'SecurityError');
+ expect(e.message, 'SecurityError: DOM Exception 18');
+ }
+ });
+ test('EventException', () {
blois 2013/01/15 01:31:56 seems like this test should not be included in the
Emily Fortuna 2013/01/15 02:21:06 Done.
+ final event = new Event('Event');
+ // Intentionally do not initialize it!
+ try {
+ document.$dom_dispatchEvent(event);
+ } on EventException catch (e) {
+ expect(e.code, EventException.UNSPECIFIED_EVENT_TYPE_ERR);
+ expect(e.name, 'UNSPECIFIED_EVENT_TYPE_ERR');
+ expect(e.message,
+ 'UNSPECIFIED_EVENT_TYPE_ERR: DOM Events Exception 0');
+ }
+ });
}
});
}

Powered by Google App Engine
This is Rietveld 408576698