Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1188293002: Add test for SkRegion::writeToMemory. (Closed)

Created:
5 years, 6 months ago by scroggo_chromium
Modified:
5 years, 6 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add test for SkRegion::writeToMemory. When calling SkRegion::writeToMemory(NULL), it should return the same number of bytes that it writes when calling SkRegion::writeToMemory(buffer). Add a test to confirm this. BUG=b/21271229 Committed: https://skia.googlesource.com/skia/+/d49f48ddf70cb1afcf13b7654457de8a85c12ad2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M tests/RegionTest.cpp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
5 years, 6 months ago (2015-06-17 15:41:38 UTC) #2
djsollen
lgtm
5 years, 6 months ago (2015-06-18 13:09:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188293002/1
5 years, 6 months ago (2015-06-18 13:11:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188293002/1
5 years, 6 months ago (2015-06-18 13:11:38 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 13:16:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d49f48ddf70cb1afcf13b7654457de8a85c12ad2

Powered by Google App Engine
This is Rietveld 408576698