Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1188253013: [Android] Add a java method counting script. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a java method counting script. BUG=497911 Committed: https://crrev.com/465efd23412d344b5bf72e7dc9401016fa78f1f7 Cr-Commit-Position: refs/heads/master@{#335296}

Patch Set 1 #

Total comments: 4

Patch Set 2 : mikecase comments #

Patch Set 3 : forgot one #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, --1 lines) Patch
A build/android/method_count.py View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A + build/android/pylib/sdk/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A build/android/pylib/sdk/dexdump.py View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
5 years, 6 months ago (2015-06-19 02:08:55 UTC) #2
mikecase (-- gone --)
https://codereview.chromium.org/1188253013/diff/1/build/android/method_count.py File build/android/method_count.py (right): https://codereview.chromium.org/1188253013/diff/1/build/android/method_count.py#newcode27 build/android/method_count.py:27: print MethodCount(args.dexfile) Can you use python logging here? Is ...
5 years, 6 months ago (2015-06-19 15:45:26 UTC) #3
jbudorick
https://codereview.chromium.org/1188253013/diff/1/build/android/method_count.py File build/android/method_count.py (right): https://codereview.chromium.org/1188253013/diff/1/build/android/method_count.py#newcode27 build/android/method_count.py:27: print MethodCount(args.dexfile) On 2015/06/19 at 15:45:26, mikecase wrote: > ...
5 years, 6 months ago (2015-06-19 16:25:56 UTC) #4
mikecase (-- gone --)
lgtm
5 years, 6 months ago (2015-06-19 17:00:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188253013/60001
5 years, 6 months ago (2015-06-19 17:02:32 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-19 18:18:55 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:20:00 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/465efd23412d344b5bf72e7dc9401016fa78f1f7
Cr-Commit-Position: refs/heads/master@{#335296}

Powered by Google App Engine
This is Rietveld 408576698