Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1188233002: Revert of Added constructor call on object in InstantiateObject method (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Added constructor call on object in InstantiateObject method (patchset #5 id:80001 of https://codereview.chromium.org/1137693003/) Reason for revert: [Sheriff] This breaks layout test expectations: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/437 See: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/437/layout-test-results/fast/dom/create-element-after-stack-overflow-pretty-diff.html Please land a needsmanualrebaseline change on the blink-side before relanding this, if the change was intended. Please include a blink trybot on relanding this. Original issue's description: > Added constructor call on object in InstantiateObject method > > I found after upgrading from 4.2.2 where apinatives.js still > existed to 4.4.56 where everything had been converted to C++ in > api-natives.cc, my constructors for ObjectTemplate instantiated objects > were no longer being called. After investigation, I noticed in > apinatives.js that a new call would handle that, but there was no > corresponding constructor call in api-natives.cc (or anywhere else > along the chain of InstantiateObject), so I added a call to > Execution::Call to actually construct the object. Forgive me if that > isn't the right place to add it (InitializeBody in objects-inl.h also > looked like a good place), or if there's a reason constructors are > not being called. > > I also added myself to the AUTHORS file in this CL. > > Committed: https://crrev.com/e61a957b2a9726294cdd2802a6a2b6e3a9ef657d > Cr-Commit-Position: refs/heads/master@{#29076} TBR=verwaest@chromium.org,svenpanne@chromium.org,dtalley@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d05cb6b30ff17fbb31e27f504764367a2d15fced Cr-Commit-Position: refs/heads/master@{#29085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M src/api-natives.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Added constructor call on object in InstantiateObject method
5 years, 6 months ago (2015-06-17 12:20:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188233002/1
5 years, 6 months ago (2015-06-17 12:20:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 12:20:55 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 12:21:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d05cb6b30ff17fbb31e27f504764367a2d15fced
Cr-Commit-Position: refs/heads/master@{#29085}

Powered by Google App Engine
This is Rietveld 408576698