Issue 11882045: Revert 176910 - Possible breakage of PlatformAppBrowserTest.Messaging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11882045: Revert 176910 - Possible breakage of PlatformAppBrowserTest.Messaging (Closed)

Created:
7 years, 11 months ago by Patrick Dubroy

Modified:
7 years, 11 months ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 176910 - Possible breakage of PlatformAppBrowserTest.Messaging http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%282%29/builds/25744/steps/browser_tests/logs/Messaging > Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator > > This CL extracts a cr.ui.BubbleButton base class from the > options.ControlledSettingIndicator so that it can be shared with the > upcoming improved about:policy page. > > BUG=134849 > TEST=Manual > > > Review URL: https://chromiumcodereview.appspot.com/11864019 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176924

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -115 lines)			Patch
M	chrome/browser/resources/options/controlled_setting.js	View	4 chunks	+59 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.css	View	1 chunk	+18 lines, -2 lines	0 comments	Download
D	chrome/browser/resources/shared/css/bubble_button.css	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	chrome/browser/resources/shared/js/cr/ui/bubble_button.js	View	1 chunk	+0 lines, -84 lines	0 comments	Download
M	chrome/browser/resources/shared_resources.grd	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)