Add components_unittests to bots

masters/master.chromium.memory.fyi/master.cfg

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes import svnpoller
 from buildbot.scheduler import Triggerable
 from buildbot.scheduler import Scheduler
 
 # These modules come from scripts/master, which must be in the PYTHONPATH.
 from master import build_utils
@@ skipping 168 matching lines @@
   # TODO: Remove when crbug.com/112389 is fixed.
   'component=static_library '
   'werror= '
 )
 heapcheck_cros_gyp_defines = heapcheck_gyp_defines + ' chromeos=1'
 
 # IMPORTANT NOTE about adding new tests.
 # If you want to add a new test, you first need to make sure it's:
 # a) buildable,
 # b) runnable by the tools and
 # c) the e-mail notifier is configured to watch for its failures.

[iannucci, 2013/01/15 23:53:19]

It would be worth following this IMPORTANT NOTE :P. Or, just skip adding it to
valgrind tests (though if these tests are currently running under valgrind, we
should probably keep them that way)

 #
 # Also, please do your best to estimate the time it takes to run the new test
 # under the tool and order the tests in a short-job-first manner if possible.
 #
 # Regarding (a),
 #   New Valgrind/Mac tests must first be added as dependencies to the
 #     'chromium_builder_dbg_valgrind_mac' target in src/build/all.gyp;
 #   New TSan/Win tests must first be added as dependencies to the
 #     'chromium_builder_dbg_tsan_win' target in src/build/all.gyp;
 #   New DrMemory/Win tests must first be added as dependencies to the
 #     'chromium_builder_dbg_drmemory_win' target in src/build/all.gyp;
 #   
 # Regarding (b),
 #   'chrome_tests.py' must be updated to handle the test name,
 #   without the 'TOOL_' prefix, where 'chrome_tests.py' is located
 #     at tools/heapcheck/ for Heapchecker tests,
 #     at tools/valgrind/ for other tools.
 #
 # Regarding (c),
 #   See notifier_cfg.py for the existing tests and see the 'category' of the
 #   builder you're dealing with.
 
 f_chromium_rel_linux_valgrind_builder = F_LINUX(
     target='Release',
     slave_type='Builder',
     options=['--compiler=goma',
              'base_unittests',
+             'components_unittests',
              'content_unittests',
              'crypto_unittests',
              'device_unittests',
              'googleurl_unittests',
              'ipc_tests',
              'media_unittests',
              'net_unittests',
              'ppapi_unittests',
              'printing_unittests',
              'remoting_unittests',
              'sandbox_linux_unittests',
              'sql_unittests',
              'sync_unit_tests',
              'ui_unittests',
              'unit_tests',
              ],
     factory_properties={
         'gclient_env': { 'GYP_DEFINES' : 'build_for_tool=memcheck' },
         'trigger': 'chromium_linux_valgrind',
     }
 )
 
 f_chromium_rel_linux_valgrind_tests_1 = F_LINUX(
     target='Release',
     slave_type='Tester',
     build_url=chromium_linux_valgrind_archive,
     tests=['valgrind_crypto',
            'valgrind_content',

[iannucci, 2013/01/15 23:53:19]

I suspect that you'll need to do something equivalent to valgrind_content here
for components. This probably means doing a grep through all the build stuff for
valgrind and making sure that adding an entry to _AddTests is all that's
necessary.

            'valgrind_sync',
            'valgrind_net',
            ],
     factory_properties={ 'needs_valgrind' : True, })
 
 f_chromium_rel_linux_valgrind_tests_2 = F_LINUX(
     target='Release',
     slave_type='Tester',
     build_url=chromium_linux_valgrind_archive,
     tests=['valgrind_googleurl',
@@ skipping 78 matching lines @@
            #'valgrind_unit_1_of_4',
            #'valgrind_unit_2_of_4',
            ])
 
 f_cr_dbg_mac_valgrind_2 = F_MAC(
     build_url=chromium_mac_valgrind_archive,
     slave_type='Tester',
     factory_properties={ 'needs_valgrind' : True, },
     # See IMPORTANT NOTE above before adding new tests.
     tests=['valgrind_net',
            'valgrind_content',

[iannucci, 2013/01/15 23:53:19]

Possibly need a valgrind_components here too

            # See above.
            #'valgrind_unit_3_of_4',
            #'valgrind_unit_4_of_4',
            ])
 
 # ChromeOS Valgrind bots:
 f_chromium_rel_chromeos_valgrind_builder = F_CR_OS(
     target='Release',
     slave_type='Builder',
     options=['--compiler=goma',
              'ash_unittests',
              'aura_unittests',
              'base_unittests',
              'chromeos_unittests',
+             'components_unittests',
              'compositor_unittests',
              'content_unittests',
              'crypto_unittests',
              'device_unittests',
              'googleurl_unittests',
              'ipc_tests',
              'media_unittests',
              'net_unittests',
              'ppapi_unittests',
              'printing_unittests',
@@ skipping 32 matching lines @@
     factory_properties={ 'needs_valgrind' : True, 'chromeos': True })
 
 f_chromium_rel_chromeos_valgrind_tests_3 = F_CR_OS(
     target='Release',
     slave_type='Tester',
     build_url=chromium_chromeos_valgrind_archive,
     tests=['valgrind_ash_unittests',
            'valgrind_aura',
            'valgrind_base',
            'valgrind_chromeos_unittests',
            'valgrind_content',

[iannucci, 2013/01/15 23:53:19]

ditto

            'valgrind_compositor',
            'valgrind_crypto',
            'valgrind_sandbox',
            'valgrind_views',
            ],
     factory_properties={ 'needs_valgrind' : True, 'chromeos': True })
 
 f_chromium_rel_chromeos_valgrind_tests_4 = F_CR_OS(
     target='Release',
     slave_type='Tester',
@@ skipping 67 matching lines @@
     factory_properties={ 'needs_valgrind' : True, })
 
 f_chromium_rel_linux_tsan_3 = F_LINUX(
     target='Release',
     slave_type='Tester',
     build_url=chromium_linux_valgrind_archive,
     # See IMPORTANT NOTE above before adding new tests.
     tests=['tsan_crypto',
            'tsan_remoting',
            'tsan_sync',
            'tsan_content',

[iannucci, 2013/01/15 23:53:19]

maybe? 

[iannucci, 2013/01/15 23:53:19]

maybe?

            'tsan_base',
            'tsan_unit_3_of_3',
            ],
     factory_properties={ 'needs_valgrind' : True, })
 
 f_chromium_dbg_win_tsan = F_WIN(
     target='Debug',
     # See IMPORTANT NOTE above before adding new tests.
     tests=[
       'tsan_googleurl',
@@ skipping 46 matching lines @@
       'drmemory_light_unit',
     ],
     factory_properties={'needs_drmemory': True}
 )
 
 # Heapcheck bots:
 f_chromium_dbg_linux_heapcheck = F_LINUX(
     target='Debug',
     options=['--compiler=goma',
              'base_unittests',
+             'components_unittests',
              'compositor_unittests',
              'content_unittests',
              'courgette_unittests',
              'crypto_unittests',
              'DumpRenderTree',
              'device_unittests',
              'googleurl_unittests',
              'ipc_tests',
              'media_unittests',
              'net_unittests',
              'ppapi_unittests',
              'printing_unittests',
              'remoting_unittests',
              'sql_unittests',
              'sync_unit_tests',
              'test_shell_tests',
              'ui_unittests',
              'unit_tests',
              ],
     # See IMPORTANT NOTE above before adding new tests.
     tests=['heapcheck_googleurl',
            'heapcheck_printing',
            'heapcheck_media',
            'heapcheck_content',

[iannucci, 2013/01/15 23:53:19]

here too

            'heapcheck_courgette',
            'heapcheck_remoting',
            'heapcheck_sql',
            'heapcheck_sync',
            'heapcheck_ipc',
            'heapcheck_base',
            'heapcheck_crypto',
            'heapcheck_device_unittests',
            'heapcheck_net',
            'heapcheck_ui_unittests',
            'heapcheck_unit',
            'heapcheck_test_shell',
            ],
     factory_properties={
         'gclient_env': {'GYP_DEFINES' : heapcheck_gyp_defines} },
 )
 
 # test_shell_tests are disabled on ChromeOS because of
 # crbug.com/112575.
 f_chromium_dbg_chromeos_heapcheck = F_CR_OS(
     target='Debug',
     options=['--compiler=goma',
              'ash_unittests',
              'aura_unittests',
              'base_unittests',
              'chromeos_unittests',
+             'components_unittests',
              'compositor_unittests',
              'content_unittests',
              'courgette_unittests',
              'crypto_unittests',
              'DumpRenderTree',
              'device_unittests',
              'googleurl_unittests',
              'ipc_tests',
              'media_unittests',
              'net_unittests',
              'ppapi_unittests',
              'printing_unittests',
              'remoting_unittests',
              'sql_unittests',
              'sync_unit_tests',
              #'test_shell_tests',
              'ui_unittests',
              'unit_tests',
              'views_unittests',
              ],
     # See IMPORTANT NOTE above before adding new tests.
     tests=['heapcheck_ash_unittests',
            'heapcheck_aura',
            'heapcheck_googleurl',
            'heapcheck_printing',
            'heapcheck_media',
            'heapcheck_chromeos_unittests',
            'heapcheck_compositor',
            'heapcheck_content',

[iannucci, 2013/01/15 23:53:19]

possibly?

            'heapcheck_courgette',
            'heapcheck_remoting',
            'heapcheck_sql',
            'heapcheck_sync',
            'heapcheck_ipc',
            'heapcheck_base',
            'heapcheck_crypto',
            'heapcheck_device_unittests',
            'heapcheck_net',
            'heapcheck_ui_unittests',
@@ skipping 306 matching lines @@
     enable_http_status_push=ActiveMaster.is_production_host)
 
 if ActiveMaster.is_production_host:
   import notifier_cfg
   notifier_cfg.Update(config, ActiveMaster, c)
 
 ####### PROJECT IDENTITY
 
 # Buildbot master url:
 c['buildbotURL'] = 'http://build.chromium.org/p/chromium.memory.fyi/'