Add components_unittests to bots

Add components_unittests to bots


BUG=169312, 170191

[kaiwang, 2013-01-15 04:39:46]

Added to most places we had content_unittests except ios related and aura
related

Really not sure if I did it right in
masters/master.tryserver.chromium/master.cfg
It's so complicated...

[iannucci, 2013-01-15 23:53:19]

Overall, it may be worthwhile splitting this into:

  * Changes to add 'components_unittests' to scripts/
  * Changes to add 'components_unittests' build/test configurations (one cl per
master)
for mem_tech in ['valgrind', 'heapcheck', 'tsan']:
    * Changes to add '%s_components' % mem_tech to scripts/
    * Changes to add '%s_components' % mem_tech build/test configurations (one
cl per master)

Or some combination therein :).  The trick is that if it's all one CL and we
have to revert it, we'll end up restarting all the masters at least three times
(apply, revert, apply fix). If we can work out the kinks on fyi, then memory
maybe (because the tsan, etc. need special treatment), it might be easier to
show that e.g. the tryserver isn't going to fall over too.

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.chromiumos/master_chromiumos_cfg.py:34:
'components_unittests',
I'm not sure if you want to shard this yet, unless you've tested it and know
it's safe already?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
File masters/master.chromium.chromiumos/master_gatekeeper_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.chromiumos/master_gatekeeper_cfg.py:21:
'components_unittests',
That will make this test a tree closer. I'm assuming that's what you want?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
File masters/master.chromium.fyi/master.cfg (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.fyi/master.cfg:598: 'net',
You'll need to add the unittest here too, if you want it to run.  Options below
is just telling the bot what to build.

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.fyi/master.cfg:838: options=['components_unittests',
Maybe not here :)

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
File masters/master.chromium.memory.fyi/master.cfg (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:189: # c) the e-mail notifier is
configured to watch for its failures.
It would be worth following this IMPORTANT NOTE :P. Or, just skip adding it to
valgrind tests (though if these tests are currently running under valgrind, we
should probably keep them that way)

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:245: 'valgrind_content',
I suspect that you'll need to do something equivalent to valgrind_content here
for components. This probably means doing a grep through all the build stuff for
valgrind and making sure that adding an entry to _AddTests is all that's
necessary.

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:344: 'valgrind_content',
Possibly need a valgrind_components here too

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:412: 'valgrind_content',
ditto

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:500: 'tsan_content',
maybe?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:500: 'tsan_content',
maybe?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:591: 'heapcheck_content',
here too

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory.fyi/master.cfg:647: 'heapcheck_content',
possibly?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
File masters/master.chromium.memory/master_linux_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.chromiu...
masters/master.chromium.memory/master_linux_cfg.py:49: 'components_unittests',
Hmm... weird. It doesn't look like content_browsertests is actually run anywhere
in this master (just built). I wonder why that is...

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:379: 'content_unittests',
No aura?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:406: 'content_unittests',
same

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:860: 'content_unittests',
Are we leaving out ios on purpose?

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:923: 'crypto',
Probably need components here (which will turn into valgrind_components, which
needs to get added to _AddTests)

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:1043: 'content',
Same as valgrind above

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:1328: 'device_unittests',
more aura

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:1371: 'content_unittests',
No asan? Though it looks like content_unittests is not actually run below
either.

https://chromiumcodereview.appspot.com/11882038/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:1501: 'media',
same as tsan/valgrind

[kaiwang, 2013-01-16 01:50:53]

Reverted memory related stuff. It's so complicated...

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.chrom...
File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right):

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.chrom...
masters/master.chromium.chromiumos/master_chromiumos_cfg.py:34:
'components_unittests',
The content_unittests is already sharded. So I think it's fine

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.chrom...
File masters/master.chromium.chromiumos/master_gatekeeper_cfg.py (right):

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.chrom...
masters/master.chromium.chromiumos/master_gatekeeper_cfg.py:21:
'components_unittests',
Yes, components dir will contain important components for browser on different
platforms

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.fyi/m...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:598: 'net',
Removed from below

https://codereview.chromium.org/11882038/diff/1/masters/master.chromium.fyi/m...
masters/master.chromium.fyi/master.cfg:838: options=['components_unittests',
On 2013/01/15 23:53:19, iannucci wrote:
> Maybe not here :)

Done.

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:379: 'content_unittests',
current planed tests are all none aura related

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:860: 'content_unittests',
yes, components_unittests is not a target on ios

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:923: 'crypto',
On 2013/01/15 23:53:19, iannucci wrote:
> Probably need components here (which will turn into valgrind_components, which
> needs to get added to _AddTests)

Done.

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:1043: 'content',
On 2013/01/15 23:53:19, iannucci wrote:
> Same as valgrind above

Done.

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:1371: 'content_unittests',
added..

https://codereview.chromium.org/11882038/diff/1/masters/master.tryserver.chro...
masters/master.tryserver.chromium/master.cfg:1501: 'media',
On 2013/01/15 23:53:19, iannucci wrote:
> same as tsan/valgrind

Done.

[iannucci, 2013-01-16 19:25:36]

One more round :/

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
File masters/master.chromium.lkgr/lkgr_finder.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium.lkgr/lkgr_finder.py:92: 'components_unittests',
You only want this if the test is running in chromium.win

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium.lkgr/lkgr_finder.py:178: 'components_unittests',
You only want this if the test is running in chromium.mac

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
File masters/master.chromium.mac/master_gatekeeper_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium.mac/master_gatekeeper_cfg.py:22: 'components_unittests',
You'll need to make sure that this test is running somewhere in
master.chromium.mac/*cfg* in order to add it to gatekeeper.

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
File masters/master.chromium.memory/master_linux_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium.memory/master_linux_cfg.py:49: 'components_unittests',
I'm not really sure this is necessary, since it doesn't look like you're running
the test on any of the Tester machines below. I would either not build the test
here, or add components_unittests to one of the testers

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
File masters/master.chromium.win/master_gatekeeper_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium.win/master_gatekeeper_cfg.py:25: 'components_unittests',
If you're adding it to the win gatekeeper, you'll need to make sure it's running
this test in master.chromium.win/*cfg* . Otherwise drop this

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
File masters/master.chromium/master_gatekeeper_cfg.py (right):

https://chromiumcodereview.appspot.com/11882038/diff/14001/masters/master.chr...
masters/master.chromium/master_gatekeeper_cfg.py:21: 'components_unittests',
Not really necessary to add, since none of the testers in master.chromium
actually run real tests (in fact, this whole testers section is actually
useless).

[kaiwang, 2013-01-16 19:49:15]

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.l...
File masters/master.chromium.lkgr/lkgr_finder.py (right):

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.l...
masters/master.chromium.lkgr/lkgr_finder.py:92: 'components_unittests',
Yes, components_unittests will be running on win

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.l...
masters/master.chromium.lkgr/lkgr_finder.py:178: 'components_unittests',
Same on mac

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.m...
File masters/master.chromium.mac/master_gatekeeper_cfg.py (right):

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.m...
masters/master.chromium.mac/master_gatekeeper_cfg.py:22: 'components_unittests',
I'm following content_unittests... I noticed the only other 2 places
content_unittests appears are both for ios...

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.m...
File masters/master.chromium.memory/master_linux_cfg.py (right):

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.m...
masters/master.chromium.memory/master_linux_cfg.py:49: 'components_unittests',
Done, removed

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.w...
File masters/master.chromium.win/master_gatekeeper_cfg.py (right):

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium.w...
masters/master.chromium.win/master_gatekeeper_cfg.py:25: 'components_unittests',
I'm a bit confused.. In master.chromium.win/*cfg*, the only place mentioned
content_unittests is in

F('dbg_aura_test_2', win_tester().ChromiumFactory(

But content_unittests does run on win dbg, e.g.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%283%29/buil...

Where should I add components_unittests to make it run on same bot?

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium/m...
File masters/master.chromium/master_gatekeeper_cfg.py (right):

https://codereview.chromium.org/11882038/diff/14001/masters/master.chromium/m...
masters/master.chromium/master_gatekeeper_cfg.py:21: 'components_unittests',
On 2013/01/16 19:25:36, iannucci wrote:
> Not really necessary to add, since none of the testers in master.chromium
> actually run real tests (in fact, this whole testers section is actually
> useless).

Done.

[iannucci, 2013-01-17 02:55:08]

This lgtm. It will be best to land in chunks, scripts change first, and then one
master at a time :)