Activate LayerImpl tree with sync+push instead of pointer swap

cc/layer.h

Index: cc/layer.h
diff --git a/cc/layer.h b/cc/layer.h
index a510ab60e00df897e0189bb3b931bd626fcc18af..b324ce99c54a93e568a1da0a679faeb20531e353 100644
--- a/cc/layer.h
+++ b/cc/layer.h
@@ -67,6 +67,7 @@ public:
     void setChildren(const LayerList&);
 
     const LayerList& children() const { return m_children; }
+    Layer* childAt(size_t index) const;

[enne (OOO), 2013/01/17 23:34:55]

Can this be not const?

[jamesr, 2013/01/18 01:16:42]

No, TreeSynchronizer calls Layer::pushPropertiesTo() on the return value and
those functions aren't (generally) const

[enne (OOO), 2013/01/18 01:21:35]

Maybe you misunderstood? I was asking if this could instead be:

    Layer* childAt(size_t index);

...just for general "don't return a non-const pointer from a const member
function" reasons.

[jamesr, 2013/01/18 01:27:14]

Oh right!  Definitely, anyone calling this should have a non-const pointer.

 
     void setAnchorPoint(const gfx::PointF&);
     gfx::PointF anchorPoint() const { return m_anchorPoint; }
@@ -291,6 +292,9 @@ public:
 
     virtual bool canClipSelf() const;
 
+    // Constructs a LayerImpl of the correct runtime type for this Layer type.
+    virtual scoped_ptr<LayerImpl> createLayerImpl(LayerTreeImpl* treeImpl);
+
 protected:
     friend class LayerImpl;
     friend class TreeSynchronizer;
@@ -315,8 +319,6 @@ protected:
 
     scoped_refptr<Layer> m_maskLayer;
 
-    // Constructs a LayerImpl of the correct runtime type for this Layer type.
-    virtual scoped_ptr<LayerImpl> createLayerImpl(LayerTreeImpl* treeImpl);
     int m_layerId;
 
     // When true, the layer is about to perform an update. Any commit requests