Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/telemetry/telemetry/possible_browser.py

Issue 11882033: Telemetry support for extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/possible_browser.py
===================================================================
--- tools/telemetry/telemetry/possible_browser.py (revision 179975)
+++ tools/telemetry/telemetry/possible_browser.py (working copy)
@@ -7,9 +7,10 @@
Call Create() to launch the browser and begin manipulating it..
"""
- def __init__(self, browser_type, options):
+ def __init__(self, browser_type, options, supports_extensions):
nduca 2013/02/01 00:25:50 please dont edit this. Its hard to read. Look at h
achuithb 2013/02/06 00:23:03 I'm doing this, but that's not sufficient. Possibl
achuithb 2013/02/07 01:30:46 Ok, this is fixed now. I've introduced SupportsOpt
self.browser_type = browser_type
self._options = options
+ self._supports_extensions = supports_extensions
def __repr__(self):
return 'PossibleBrowser(browser_type=%s)' % self.browser_type
@@ -18,5 +19,9 @@
def options(self):
return self._options
+ @property
+ def supports_extensions(self):
+ return self._supports_extensions
+
def Create(self):
raise NotImplementedError()

Powered by Google App Engine
This is Rietveld 408576698