Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/telemetry/telemetry/desktop_browser_backend.py

Issue 11882033: Telemetry support for extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: copyright Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/crx_id.py ('k') | tools/telemetry/telemetry/desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/desktop_browser_backend.py
===================================================================
--- tools/telemetry/telemetry/desktop_browser_backend.py (revision 182312)
+++ tools/telemetry/telemetry/desktop_browser_backend.py (working copy)
@@ -14,7 +14,9 @@
Mac or Windows.
"""
def __init__(self, options, executable, is_content_shell):
- super(DesktopBrowserBackend, self).__init__(is_content_shell, options)
+ super(DesktopBrowserBackend, self).__init__(
+ is_content_shell=is_content_shell,
+ supports_extensions=not is_content_shell, options=options)
# Initialize fields so that an explosion during init doesn't break in Close.
self._proc = None
@@ -25,6 +27,10 @@
if not self._executable:
raise Exception('Cannot create browser, no executable found!')
+ if len(options.extensions_to_load) > 0 and is_content_shell:
+ raise browser_backend.ExtensionsNotSupportedException(
+ 'Content shell does not support extensions.')
+
self._port = util.GetAvailableLocalPort()
args = [self._executable]
« no previous file with comments | « tools/telemetry/telemetry/crx_id.py ('k') | tools/telemetry/telemetry/desktop_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698