Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: tools/telemetry/telemetry/cros_browser_finder.py

Issue 11882033: Telemetry support for extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: copyright Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/cros_browser_backend.py ('k') | tools/telemetry/telemetry/crx_id.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/cros_browser_finder.py
===================================================================
--- tools/telemetry/telemetry/cros_browser_finder.py (revision 182312)
+++ tools/telemetry/telemetry/cros_browser_finder.py (working copy)
@@ -16,10 +16,9 @@
])
class PossibleCrOSBrowser(possible_browser.PossibleBrowser):
- """A launchable android browser instance."""
+ """A launchable chromeos browser instance."""
def __init__(self, browser_type, options, *args):
- super(PossibleCrOSBrowser, self).__init__(
- browser_type, options)
+ super(PossibleCrOSBrowser, self).__init__(browser_type, options)
self._args = args
def __repr__(self):
@@ -32,6 +31,9 @@
backend.SetBrowser(b)
return b
+ def SupportsOptions(self, options):
+ return True
+
def FindAllAvailableBrowsers(options):
"""Finds all the desktop browsers available on this machine."""
if options.cros_remote == None:
@@ -75,4 +77,4 @@
if not cri.FileExistsOnDevice('/opt/google/chrome/chrome'):
logging.warn('Could not find a chrome on ' % cri.hostname)
- return [PossibleCrOSBrowser('cros-chrome', options, False, cri)]
+ return [PossibleCrOSBrowser('cros-chrome', options, cri)]
« no previous file with comments | « tools/telemetry/telemetry/cros_browser_backend.py ('k') | tools/telemetry/telemetry/crx_id.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698