tools/telemetry/telemetry/extension_page.py - Issue 11882033: Telemetry support for extensions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/extension_page.py

Issue 11882033: Telemetry support for extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: wait for document ready state Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tools/telemetry/telemetry/extension_list_backend.py ('K') | « tools/telemetry/telemetry/extension_list_backend.py ('k') | tools/telemetry/telemetry/extension_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 DEFAULT_EXTENSION_TIMEOUT = 60

	6

	7 class ExtensionPage(object):

	8 """Represents a an extension page in the browser"""

	9 def __init__(self, context):

	10 self._context = context
	dtu 2013/01/30 00:01:49 Use a TabBackend instead of a Tab here. Call it se Use a TabBackend instead of a Tab here. Call it self._extension_page_backend. Rename TabBackend to InspectorBackend. achuithb 2013/01/30 10:01:56 Done. Show quoted text On 2013/01/30 00:01:49, Dave Tu wrote: > Use a TabBackend instead of a Tab here. Call it self._extension_page_backend. > Rename TabBackend to InspectorBackend. Done.
	11

	12 def __enter__(self):
	dtu 2013/01/30 00:01:49 Don't need enter and exit. Don't need enter and exit. achuithb 2013/01/30 10:01:56 Done. Show quoted text On 2013/01/30 00:01:49, Dave Tu wrote: > Don't need enter and exit. Done.
	13 return self

	14

	15 def __exit__(self, *args):

	16 self._context.Close()

	17

	18 def EvaluateJavaScript(self, expr, timeout=DEFAULT_EXTENSION_TIMEOUT):
	dtu 2013/01/30 00:01:49 Also include ExecuteJavaScript. Also include ExecuteJavaScript. achuithb 2013/01/30 10:01:56 Done. Show quoted text On 2013/01/30 00:01:49, Dave Tu wrote: > Also include ExecuteJavaScript. Done.
	19 self._context.WaitForDocumentReadyStateToBeInteractiveOrBetter()
	dtu 2013/01/30 00:01:49 I think Waiting is the responsibility of the calle I think Waiting is the responsibility of the caller. This should just be a simple pass-through to the backend. achuithb 2013/01/30 10:01:56 Done. Show quoted text On 2013/01/30 00:01:49, Dave Tu wrote: > I think Waiting is the responsibility of the caller. This should just be a > simple pass-through to the backend. Done.
	20 return self._context.EvaluateJavaScript(expr, timeout)

OLD	NEW